From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 0CE7B29DF8 for ; Mon, 28 Apr 2014 11:47:57 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 8BFA5AC003 for ; Mon, 28 Apr 2014 09:47:56 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id KjyalzGxLGTFrWPX (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 28 Apr 2014 09:47:55 -0700 (PDT) Date: Mon, 28 Apr 2014 09:47:54 -0700 From: Christoph Hellwig Subject: Re: [PATCH] xfs: test for shut down fs in xfs_dir_fsync() Message-ID: <20140428164754.GA17472@infradead.org> References: <535E8344.2070209@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <535E8344.2070209@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Boris Ranto , xfs-oss On Mon, Apr 28, 2014 at 11:35:16AM -0500, Eric Sandeen wrote: > Similar to xfs_file_fsync(), I think xfs_dir_fsync() needs > to test for a shut down fs, It probably should. > lest we go down paths we'll > never be able to complete; Boris reported that during some > stress tests he had threads stuck in xlog_cil_force_lsn > via xfs_dir_fsync(). But this could still happen if we get a shutdown coming in after that test. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs