From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: truncate_setsize should be outside transactions
Date: Fri, 2 May 2014 16:47:01 +1000 [thread overview]
Message-ID: <20140502064700.GB26353@dastard> (raw)
In-Reply-To: <20140502050053.GA17578@infradead.org>
On Thu, May 01, 2014 at 10:00:53PM -0700, Christoph Hellwig wrote:
> On Thu, May 01, 2014 at 09:54:43PM -0700, Christoph Hellwig wrote:
> > On Fri, May 02, 2014 at 08:39:39AM +1000, Dave Chinner wrote:
> > > This issue with xfs_setattr_size() was introduced back in 2010 by
> > > commit fa9b227 ("xfs: new truncate sequence") which moved the page
> > > cache truncate from outside the transaction context (what was
> > > xfs_itruncate_data()) to inside the transaction context as a call to
> > > truncate_setsize().
> >
> > And it was moved because we should only call truncate_setsize once
> > the truncate can't fail any more. So to move it out of transaction
> > context it needs to move after the commit of the transaction(s).
>
> Actually that's only true for the i_size update. So I guess
> we need to call truncate_pagecache were you put the truncate_setsize
> now, and then update i_size later, together with the updates of the
> XFS di_size.
OK, that seems reasonable. I'll add a comment to ensure that we
don't break it in future ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-02 6:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 22:39 [PATCH] xfs: truncate_setsize should be outside transactions Dave Chinner
2014-05-02 4:54 ` Christoph Hellwig
2014-05-02 5:00 ` Christoph Hellwig
2014-05-02 6:47 ` Dave Chinner [this message]
2014-05-02 7:00 ` [PATCH V2] " Dave Chinner
2014-05-02 10:08 ` Christoph Hellwig
2014-05-02 23:23 ` Dave Chinner
2014-05-03 15:16 ` Christoph Hellwig
2014-05-04 0:06 ` Dave Chinner
2014-05-05 5:19 ` [PATCH V3] " Dave Chinner
2014-05-06 7:52 ` Christoph Hellwig
2014-05-02 12:50 ` [PATCH V2] " Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502064700.GB26353@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox