From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/5] xfstests: fixes for the free inode btree
Date: Sat, 3 May 2014 09:48:31 +1000 [thread overview]
Message-ID: <20140502234831.GG26353@dastard> (raw)
In-Reply-To: <1399050842-19633-1-git-send-email-bfoster@redhat.com>
On Fri, May 02, 2014 at 01:13:57PM -0400, Brian Foster wrote:
> Hi all,
>
> This series is a few xfstests fixes and addons for the finobt. Patch 1
> fixes xfs/030 to work correctly on finobt-enabled filesystems. Patches 2
> and 3 add support for finobt-oriented tests via require functions and
> repair filter updates. Patch 4 adds a new test for targeted repair of
> finobt filesystems. Patch 5 adds a stress test that creates/modifies a
> sparsely allocated set of inodes to effectively exercise the finobt in
> conjunction with an fsstress workload.
>
> xfs/010 runs very quickly. xfs/013 runs for 5-10 minutes on my smallish
> VM running against a single spindle, so I've been back and forth on
> whether it should be part of the auto group. Thoughts, reviews, flames
> appreciated...
5-10 minutes is probably right at the edge for auto, but I think
that most people won't be testing this any time soon. Hence I'd
include it by default in the auto group, and if people complain
about the runtime when they start testing it, we can revist that
choice. FWIW, I'd also include it in the metadata group so that it
gets exercised when people run that group....
I had a quick eyeball of the changes, and nothing major stood out.
The only thing I noticed was a missing "wait" in the _cleanup
function of xfs/013 after killing all the fsstress processes. It
should probably using killall -9 as well. If we don't wait, then the
unmount will fail and if the fsstress processes don't die it will
affect every test after that...
I'll probably have more suggestions once I've run the tests ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-02 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 17:13 [PATCH 0/5] xfstests: fixes for the free inode btree Brian Foster
2014-05-02 17:13 ` [PATCH 1/5] xfs/030: filter out extra repair noise for finobt enabled fs' Brian Foster
2014-05-02 17:13 ` [PATCH 2/5] xfstests: add _require_xfs_[mkfs_]finobt() checks for finobt tests Brian Foster
2014-05-02 17:14 ` [PATCH 3/5] xfstests: filter agno/ino repair output for finobt Brian Foster
2014-05-02 17:14 ` [PATCH 4/5] xfs/010: test repair for finobt corruption Brian Foster
2014-05-02 17:14 ` [PATCH 5/5] xfs/013: stress the free inode btree Brian Foster
2014-05-02 23:48 ` Dave Chinner [this message]
2014-05-05 11:34 ` [PATCH 0/5] xfstests: fixes for " Brian Foster
2014-05-21 0:20 ` Dave Chinner
2014-05-21 11:31 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502234831.GG26353@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).