Re: [PATCH 3/5] xfs: fold xfs_attr_remove_int into xfs_attr_remove

Brian Foster
2014-05-05T21:08:42Z

On Tue, May 06, 2014 at 06:56:53AM +1000, Dave Chinner wrote:
> On Mon, May 05, 2014 at 04:21:28PM -0400, Brian Foster wrote:
> > On Sat, May 03, 2014 at 05:20:13PM +0200, Christoph Hellwig wrote:
> > > Also remove a useless ilock roundtrip for the first attr fork check, it's
> > > racy anyway and we redo it later under the ilock before we start the removal.
> > >
> > > Plus various minor style fixes to the new xfs_attr_remove.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> .....
> > > @@ -487,35 +497,26 @@ xfs_attr_remove_int(xfs_inode_t *dp, struct xfs_name *name, int flags)
> > > */
> > > xfs_trans_ijoin(args.trans, dp, 0);
> > >
> > > - /*
> > > - * Decide on what work routines to call based on the inode size.
> > > - */
> > > if (!xfs_inode_hasattr(dp)) {
> > > error = XFS_ERROR(ENOATTR);
> >
> > I suppose we probably want to nuke the XFS_ERROR() while we're here..?
> > Otherwise, it looks good.
>
> No need, I'll do that at the end of the dev cycle for everything.
>

Sounds good.

Reviewed-by: Brian Foster <bfoster@redhat.com>

> Cheers,
>
> Dave.
>
> --
> Dave Chinner
> david@fromorbit.com
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs