From: Brian Foster <bfoster@redhat.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 5/6] xfsprogs: use xfs_icluster_size_fsb in xfs_ialloc_inode_init
Date: Mon, 5 May 2014 17:10:31 -0400 [thread overview]
Message-ID: <20140505211030.GF13973@laptop.bfoster> (raw)
In-Reply-To: <536784D9.1030502@oracle.com>
On Mon, May 05, 2014 at 08:32:25PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Use xfs_icluster_size_fsb() in xfs_ialloc_inode_init(), rename variable
> ninodes to inodes_per_cluster as the latter is more meaningful.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> libxfs/xfs_ialloc.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
> index a3a1c75..7d2ae8d 100644
> --- a/libxfs/xfs_ialloc.c
> +++ b/libxfs/xfs_ialloc.c
> @@ -146,7 +146,7 @@ xfs_ialloc_inode_init(
> {
> struct xfs_buf *fbuf;
> struct xfs_dinode *free;
> - int blks_per_cluster, nbufs, ninodes;
> + int nbufs, blks_per_cluster, inodes_per_cluster;
> int version;
> int i, j;
> xfs_daddr_t d;
> @@ -157,16 +157,9 @@ xfs_ialloc_inode_init(
> * For small block sizes, manipulate the inodes in buffers
> * which are multiples of the blocks size.
> */
> - if (mp->m_sb.sb_blocksize >= mp->m_inode_cluster_size) {
> - blks_per_cluster = 1;
> - nbufs = length;
> - ninodes = mp->m_sb.sb_inopblock;
> - } else {
> - blks_per_cluster = mp->m_inode_cluster_size /
> - mp->m_sb.sb_blocksize;
> - nbufs = length / blks_per_cluster;
> - ninodes = blks_per_cluster * mp->m_sb.sb_inopblock;
> - }
> + blks_per_cluster = xfs_icluster_size_fsb(mp);
> + inodes_per_cluster = blks_per_cluster << mp->m_sb.sb_inopblog;
> + nbufs = length / blks_per_cluster;
>
> /*
> * Figure out what version number to use in the inodes we create. If
> @@ -222,7 +215,7 @@ xfs_ialloc_inode_init(
> /* Initialize the inode buffers and log them appropriately. */
> fbuf->b_ops = &xfs_inode_buf_ops;
> xfs_buf_zero(fbuf, 0, BBTOB(fbuf->b_length));
> - for (i = 0; i < ninodes; i++) {
> + for (i = 0; i < inodes_per_cluster; i++) {
> int ioffset = i << mp->m_sb.sb_inodelog;
> uint isize = xfs_dinode_size(version);
>
> --
> 1.8.3.2
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-05 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 12:32 [PATCH 5/6] xfsprogs: use xfs_icluster_size_fsb in xfs_ialloc_inode_init Jeff Liu
2014-05-05 21:10 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505211030.GF13973@laptop.bfoster \
--to=bfoster@redhat.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox