From: Brian Foster <bfoster@redhat.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap
Date: Mon, 5 May 2014 17:10:39 -0400 [thread overview]
Message-ID: <20140505211038.GG13973@laptop.bfoster> (raw)
In-Reply-To: <536784DF.5040509@oracle.com>
On Mon, May 05, 2014 at 08:32:31PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Use xfs_icluster_size_fsb() in xfs_imap().
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> libxfs/xfs_ialloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
> index 7d2ae8d..c8967db 100644
> --- a/libxfs/xfs_ialloc.c
> +++ b/libxfs/xfs_ialloc.c
> @@ -1353,7 +1353,7 @@ xfs_imap(
> return XFS_ERROR(EINVAL);
> }
>
> - blks_per_cluster = mp->m_inode_cluster_size >> mp->m_sb.sb_blocklog;
> + blks_per_cluster = xfs_icluster_size_fsb(mp);
>
> /*
> * For bulkstat and handle lookups, we have an untrusted inode number
> @@ -1374,7 +1374,7 @@ xfs_imap(
> * If the inode cluster size is the same as the blocksize or
> * smaller we get to the buffer by simple arithmetics.
> */
> - if (mp->m_inode_cluster_size <= mp->m_sb.sb_blocksize) {
> + if (blks_per_cluster == 1) {
> offset = XFS_INO_TO_OFFSET(mp, ino);
> ASSERT(offset < mp->m_sb.sb_inopblock);
>
> --
> 1.8.3.2
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-05 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 12:32 [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap Jeff Liu
2014-05-05 21:10 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505211038.GG13973@laptop.bfoster \
--to=bfoster@redhat.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox