* [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap
@ 2014-05-05 12:32 Jeff Liu
2014-05-05 21:10 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Liu @ 2014-05-05 12:32 UTC (permalink / raw)
To: xfs@oss.sgi.com
From: Jie Liu <jeff.liu@oracle.com>
Use xfs_icluster_size_fsb() in xfs_imap().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
libxfs/xfs_ialloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
index 7d2ae8d..c8967db 100644
--- a/libxfs/xfs_ialloc.c
+++ b/libxfs/xfs_ialloc.c
@@ -1353,7 +1353,7 @@ xfs_imap(
return XFS_ERROR(EINVAL);
}
- blks_per_cluster = mp->m_inode_cluster_size >> mp->m_sb.sb_blocklog;
+ blks_per_cluster = xfs_icluster_size_fsb(mp);
/*
* For bulkstat and handle lookups, we have an untrusted inode number
@@ -1374,7 +1374,7 @@ xfs_imap(
* If the inode cluster size is the same as the blocksize or
* smaller we get to the buffer by simple arithmetics.
*/
- if (mp->m_inode_cluster_size <= mp->m_sb.sb_blocksize) {
+ if (blks_per_cluster == 1) {
offset = XFS_INO_TO_OFFSET(mp, ino);
ASSERT(offset < mp->m_sb.sb_inopblock);
--
1.8.3.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap
2014-05-05 12:32 [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap Jeff Liu
@ 2014-05-05 21:10 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2014-05-05 21:10 UTC (permalink / raw)
To: Jeff Liu; +Cc: xfs@oss.sgi.com
On Mon, May 05, 2014 at 08:32:31PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Use xfs_icluster_size_fsb() in xfs_imap().
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> libxfs/xfs_ialloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
> index 7d2ae8d..c8967db 100644
> --- a/libxfs/xfs_ialloc.c
> +++ b/libxfs/xfs_ialloc.c
> @@ -1353,7 +1353,7 @@ xfs_imap(
> return XFS_ERROR(EINVAL);
> }
>
> - blks_per_cluster = mp->m_inode_cluster_size >> mp->m_sb.sb_blocklog;
> + blks_per_cluster = xfs_icluster_size_fsb(mp);
>
> /*
> * For bulkstat and handle lookups, we have an untrusted inode number
> @@ -1374,7 +1374,7 @@ xfs_imap(
> * If the inode cluster size is the same as the blocksize or
> * smaller we get to the buffer by simple arithmetics.
> */
> - if (mp->m_inode_cluster_size <= mp->m_sb.sb_blocksize) {
> + if (blks_per_cluster == 1) {
> offset = XFS_INO_TO_OFFSET(mp, ino);
> ASSERT(offset < mp->m_sb.sb_inopblock);
>
> --
> 1.8.3.2
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-05 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-05 12:32 [PATCH 6/6] use xfs_icluster_size_fsb in xfs_imap Jeff Liu
2014-05-05 21:10 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox