From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Christoph Hellwig <hch@lst.de>,
xfs@oss.sgi.com
Subject: Re: [PATCH] common: use a relative path to fsstress
Date: Tue, 6 May 2014 00:53:52 -0700 [thread overview]
Message-ID: <20140506075352.GE21910@infradead.org> (raw)
In-Reply-To: <20140504214913.GP26353@dastard>
On Mon, May 05, 2014 at 07:49:13AM +1000, Dave Chinner wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > --- a/common/config
> > +++ b/common/config
> > @@ -134,7 +134,7 @@ export MOUNT_PROG="`set_prog_path mount`"
> > export UMOUNT_PROG="`set_prog_path umount`"
> > [ "$UMOUNT_PROG" = "" ] && _fatal "umount not found"
> >
> > -export FSSTRESS_PROG="`set_prog_path fsstress $PWD/ltp/fsstress`"
> > +export FSSTRESS_PROG="./ltp/fsstress"
>
> Why remove the set_prog_path call? i.e. this should work:
>
> +export FSSTRESS_PROG="`set_prog_path fsstress ./ltp/fsstress`"
>
> Otherwise, a comment explaining why set_prog_path is not used just
> for this binary would be appropriate....
set_prog_path is only useful for tools found in $PATH, and except for
fsstress we never use it for anything that we specify path to, so
I don't really see the need for a comment here.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-06 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 10:45 [PATCH] common: use a relative path to fsstress Christoph Hellwig, Christoph Hellwig
2014-05-04 21:49 ` Dave Chinner
2014-05-06 7:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506075352.GE21910@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox