From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] xfs: remove shared supberlock feature checking
Date: Tue, 6 May 2014 18:02:03 +1000 [thread overview]
Message-ID: <20140506080203.GC5421@dastard> (raw)
In-Reply-To: <536893DB.7050705@oracle.com>
On Tue, May 06, 2014 at 03:48:43PM +0800, Jeff Liu wrote:
>
> On 05/06 2014 11:55 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > We reject any filesystem that is mounted with this feature bit set,
> > so we don't need to check for it anywhere else. Remove the function
> > for checking if the feature bit is set and any code that uses it.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > ---
> > fs/xfs/xfs_fsops.c | 2 --
> > fs/xfs/xfs_sb.c | 3 ++-
> > fs/xfs/xfs_sb.h | 17 ++++-------------
> > 3 files changed, 6 insertions(+), 16 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
> > index b099799..97886a7 100644
> > --- a/fs/xfs/xfs_fsops.c
> > +++ b/fs/xfs/xfs_fsops.c
> > @@ -84,8 +84,6 @@ xfs_fs_geometry(
> > XFS_FSOP_GEOM_FLAGS_IALIGN : 0) |
> > (xfs_sb_version_hasdalign(&mp->m_sb) ?
> > XFS_FSOP_GEOM_FLAGS_DALIGN : 0) |
> > - (xfs_sb_version_hasshared(&mp->m_sb) ?
> > - XFS_FSOP_GEOM_FLAGS_SHARED : 0) |
>
> Just a trivial comments, now the XFS_FSOP_GEOM_FLAGS_SHARED is useless, so
> we can remove it from fs/xfs/xfs.h.
That's a public API header file, so removing it could break
applications. It's OK to leave it there, I think.
> Otherwise, looks good to me.
>
> Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks!
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-06 8:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 3:55 [PATCH 0/5] xfs: sanitise supberlock feature bit support Dave Chinner
2014-05-06 3:55 ` [PATCH 1/5] xfs: make superblock version checks reflect reality Dave Chinner
2014-05-06 8:29 ` Christoph Hellwig
2014-05-06 8:39 ` Dave Chinner
2014-05-06 3:55 ` [PATCH 2/5] xfs: keep sb_bad_features2 the same a sb_features2 Dave Chinner
2014-05-06 8:20 ` Christoph Hellwig
2014-05-06 3:55 ` [PATCH 3/5] xfs: turn NLINK feature on by default Dave Chinner
2014-05-06 8:15 ` Christoph Hellwig
2014-05-06 9:06 ` Dave Chinner
2014-05-06 3:55 ` [PATCH 4/5] xfs: don't need dirv2 checks anymore Dave Chinner
2014-05-06 8:16 ` Christoph Hellwig
2014-05-06 8:45 ` Dave Chinner
2014-05-06 3:55 ` [PATCH 5/5] xfs: remove shared supberlock feature checking Dave Chinner
2014-05-06 7:48 ` Jeff Liu
2014-05-06 8:02 ` Dave Chinner [this message]
2014-05-06 8:18 ` Christoph Hellwig
2014-05-06 8:28 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2014-05-16 23:00 [PATCH 0/5 V2] xfs: sanitise superblock feature bit support Dave Chinner
2014-05-16 23:00 ` [PATCH 5/5] xfs: remove shared supberlock feature checking Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506080203.GC5421@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox