From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8)
Date: Tue, 6 May 2014 01:37:44 -0700 [thread overview]
Message-ID: <20140506083744.GA9976@infradead.org> (raw)
In-Reply-To: <20140506075905.GA5421@dastard>
I like this in general, but one major and one minor issue with
the include files:
- headers that just include other headers are a bad idea in general.
Either they are dependent enough that they should be merged, or
they are not, in which case they shouldn't.
In this case it seems like we should temporarily provide a
xfs_mount.h stub in userspace, and just leave all the includes
for things in libxfs.h as they were. That doesn't preclude further
merging of the headers into more sensible ones as we've started
with the disk formats.
- do we really need the separate include/ dir? That always annoys
me when editing code. It makes sense for something that is a real
public interface, which this is not.
Also is libxfs/ really the right name? libxfs in userspace has quite
a bit more code than this, so maybe we should just called this "shared"
for the shared user/kernel code?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-06 8:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 7:18 [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8 xfs
2014-05-06 7:59 ` [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8) Dave Chinner
2014-05-06 8:37 ` Christoph Hellwig [this message]
2014-05-06 9:00 ` Dave Chinner
2014-05-09 7:29 ` Christoph Hellwig
2014-05-09 21:45 ` Dave Chinner
2014-05-06 8:43 ` Christoph Hellwig
2014-05-06 9:05 ` Dave Chinner
2014-05-07 14:48 ` Brian Foster
2014-05-07 22:47 ` Dave Chinner
2014-05-08 1:12 ` Dave Chinner
2014-05-08 12:02 ` Brian Foster
2014-05-08 12:54 ` Christoph Hellwig
2014-05-08 13:45 ` Brian Foster
2014-05-08 21:21 ` Dave Chinner
2014-05-09 7:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506083744.GA9976@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox