From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8)
Date: Fri, 9 May 2014 07:21:20 +1000 [thread overview]
Message-ID: <20140508212120.GE26353@dastard> (raw)
In-Reply-To: <20140508134520.GC47272@bfoster.bfoster>
On Thu, May 08, 2014 at 09:45:20AM -0400, Brian Foster wrote:
> On Thu, May 08, 2014 at 05:54:05AM -0700, Christoph Hellwig wrote:
> > On Thu, May 08, 2014 at 08:02:28AM -0400, Brian Foster wrote:
> > > Missing a $ here...
> > >
> > > Adding that, the single threaded build still breaks for me. E.g.,
> > >
> > > - rm -rf fs/xfs
> > > - git checkout -- .
> > > - make
> >
> > The kernel build systems doesn't support building a single module from
> > multiple makefiles. Take a look how to handle a subdirectory in the
> > older XFS versions that still had that linux-2.6 subdirectory, it just
> > pulls the files in the subdirectory in from the main makefile, which
> > requires some tiny hacks for the include path.
> >
>
> Good point, I was looking around for some example of this and didn't see
> anything obvious, but didn't think to look back to that. Indeed it does
> just reference the files in the subdirectory... thanks.
I haven't looked at that, but I'm assuming that it is just a
-include libxfs/Makefile
directive rather than using:
obj-y += libxfs/
If that's all it takes, then I'll rebase the patch on that....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-08 21:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 7:18 [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8 xfs
2014-05-06 7:59 ` [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8) Dave Chinner
2014-05-06 8:37 ` Christoph Hellwig
2014-05-06 9:00 ` Dave Chinner
2014-05-09 7:29 ` Christoph Hellwig
2014-05-09 21:45 ` Dave Chinner
2014-05-06 8:43 ` Christoph Hellwig
2014-05-06 9:05 ` Dave Chinner
2014-05-07 14:48 ` Brian Foster
2014-05-07 22:47 ` Dave Chinner
2014-05-08 1:12 ` Dave Chinner
2014-05-08 12:02 ` Brian Foster
2014-05-08 12:54 ` Christoph Hellwig
2014-05-08 13:45 ` Brian Foster
2014-05-08 21:21 ` Dave Chinner [this message]
2014-05-09 7:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508212120.GE26353@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox