From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 164F67F52 for ; Thu, 8 May 2014 16:21:24 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id EC0B330404E for ; Thu, 8 May 2014 14:21:23 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id WXxxbQPKaho85ArX for ; Thu, 08 May 2014 14:21:22 -0700 (PDT) Date: Fri, 9 May 2014 07:21:20 +1000 From: Dave Chinner Subject: Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8) Message-ID: <20140508212120.GE26353@dastard> References: <20140506071855.F152E7FBC@oss.sgi.com> <20140506075905.GA5421@dastard> <20140507144822.GA4061@bfoster.bfoster> <20140507224755.GR5421@dastard> <20140508011256.GS5421@dastard> <20140508120228.GA47272@bfoster.bfoster> <20140508125405.GA8096@infradead.org> <20140508134520.GC47272@bfoster.bfoster> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140508134520.GC47272@bfoster.bfoster> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: Christoph Hellwig , xfs@oss.sgi.com On Thu, May 08, 2014 at 09:45:20AM -0400, Brian Foster wrote: > On Thu, May 08, 2014 at 05:54:05AM -0700, Christoph Hellwig wrote: > > On Thu, May 08, 2014 at 08:02:28AM -0400, Brian Foster wrote: > > > Missing a $ here... > > > > > > Adding that, the single threaded build still breaks for me. E.g., > > > > > > - rm -rf fs/xfs > > > - git checkout -- . > > > - make > > > > The kernel build systems doesn't support building a single module from > > multiple makefiles. Take a look how to handle a subdirectory in the > > older XFS versions that still had that linux-2.6 subdirectory, it just > > pulls the files in the subdirectory in from the main makefile, which > > requires some tiny hacks for the include path. > > > > Good point, I was looking around for some example of this and didn't see > anything obvious, but didn't think to look back to that. Indeed it does > just reference the files in the subdirectory... thanks. I haven't looked at that, but I'm assuming that it is just a -include libxfs/Makefile directive rather than using: obj-y += libxfs/ If that's all it takes, then I'll rebase the patch on that.... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs