From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/9] xfs: error sign fixes for 3.15-rc6
Date: Thu, 15 May 2014 07:28:22 +1000 [thread overview]
Message-ID: <20140514212822.GS26353@dastard> (raw)
In-Reply-To: <53731B07.9040606@oracle.com>
On Wed, May 14, 2014 at 03:28:07PM +0800, Jeff Liu wrote:
> Hi Dave,
>
> On 05/13/2014 04:56 PM, Dave Chinner wrote:
> > Hi folks,
> >
> > I've been working through the mess that is the
> > error sign impedance mismatch between the core XFS code and the rest
> > of the kernel. I'm about half way through the codebase, and I've
> > found a bunch of incorrect error signs throughout the VFS interface
> > layers.
> >
> > These were effectively all found by inspection, and is
> > further evidence that we need to convert all of XFS to negative
> > errors as quickly as possible.
>
> Would you like to find a volunteer to deal with that? I have a colleague
> is trying to study XFS these days, looks this is a good task to him.
Thanks for the offer, but I've already done half the conversion of
the codebase. Hence I may as well finish it. Indeed, The sooner
I've done it, the sooner we can get it into the dev tree for
testing....
> BTW, before doing negative errors converting, should we have
> libxfs infrastructure support at first?
Makes no difference - the libxfs structural changes are just moving
files about and futzing with makefiles. It'll only take me an hour
to redo those patches from scratch, so it doesn't matter what state
the code base is in to start with. I'd prefer that the kernel libxfs
uses negative errors from the start, though ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-14 21:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 8:56 [PATCH 0/9] xfs: error sign fixes for 3.15-rc6 Dave Chinner
2014-05-13 8:56 ` [PATCH 1/9] xfs: xfs_dir_fsync() returns positive errno Dave Chinner
2014-05-13 12:46 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 2/9] xfs: fix incorrect error sign in xfs_file_aio_read Dave Chinner
2014-05-13 12:46 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 3/9] xfs: xfs_commit_metadata returns wrong errno Dave Chinner
2014-05-13 12:48 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 4/9] xfs: correct error sign on COLLAPSE_RANGE errors Dave Chinner
2014-05-13 12:49 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 5/9] xfs: fix wrong errno from xfs_initxattrs Dave Chinner
2014-05-13 12:51 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 6/9] xfs: fix wrong err sign on xfs_set_acl() Dave Chinner
2014-05-13 12:51 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 7/9] xfs: negate mount workqueue init error value Dave Chinner
2014-05-13 12:56 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 8/9] xfs: negate xfs_icsb_init_counters " Dave Chinner
2014-05-13 12:58 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 9/9] xfs: list_lru_init returns a negative error Dave Chinner
2014-05-13 13:05 ` Jeff Liu
2014-05-14 7:28 ` [PATCH 0/9] xfs: error sign fixes for 3.15-rc6 Jeff Liu
2014-05-14 21:28 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514212822.GS26353@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox