[GIT PULL] xfs: fixes for 3.15-rc6

[GIT PULL] xfs: fixes for 3.15-rc6

[Dave Chinner]

Hi Linus,

Can you please pull the updates listed below? I found a bunch of
error sign issues while determine what we need to do to rid XFS of
this problem permanently. A couple of the bugs are in data integirty
operations, a couple more are in the new COLLAPSE_RANGE code. One of
these came in through a recent ext4 merge and so I had to update the
base tree to 3.15-rc5 before fixing the issues.

-Dave.

The following changes since commit d6d211db37e75de2ddc3a4f979038c40df7cc79c:

  Linux 3.15-rc5 (2014-05-09 13:10:52 -0700)

are available in the git repository at:

  git://oss.sgi.com/xfs/xfs.git tags/xfs-for-linus-3.15-rc6

for you to fetch changes up to ee4eec478be4677b93775d17bc079efb5922b276:

  xfs: list_lru_init returns a negative error (2014-05-15 09:23:24 +1000)

----------------------------------------------------------------
xfs: fixes for 3.15-rc6

Code inspection of the XFS error number sign translations found a bunch of
issues, including returning incorrectly signed errors for some data integrity
operations. These leak to userspace and result in applications not getting the
errors correctly reported. Hence they need fixing sooner rather than later.

----------------------------------------------------------------
Dave Chinner (9):
      xfs: xfs_dir_fsync() returns positive errno
      xfs: fix incorrect error sign in xfs_file_aio_read
      xfs: xfs_commit_metadata returns wrong errno
      xfs: correct error sign on COLLAPSE_RANGE errors
      xfs: fix wrong errno from xfs_initxattrs
      xfs: fix wrong err sign on xfs_set_acl()
      xfs: negate mount workqueue init error value
      xfs: negate xfs_icsb_init_counters error value
      xfs: list_lru_init returns a negative error

 fs/xfs/xfs_export.c |    2 +-
 fs/xfs/xfs_file.c   |    8 ++++----
 fs/xfs/xfs_iops.c   |   12 ++++++------
 fs/xfs/xfs_qm.c     |   26 ++++++++++++++------------
 fs/xfs/xfs_super.c  |    4 ++--
 5 files changed, 27 insertions(+), 25 deletions(-)
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [GIT PULL] xfs: fixes for 3.15-rc6

[Christoph Hellwig]

On Fri, May 16, 2014 at 12:11:44PM +1000, Dave Chinner wrote:
> Hi Linus,
> 
> Can you please pull the updates listed below? I found a bunch of
> error sign issues while determine what we need to do to rid XFS of
> this problem permanently. A couple of the bugs are in data integirty
> operations, a couple more are in the new COLLAPSE_RANGE code. One of
> these came in through a recent ext4 merge and so I had to update the
> base tree to 3.15-rc5 before fixing the issues.

Doesn't this miss the log roundin fix?

Linus said he is away for about a weeke anyway, while we're at it.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [GIT PULL] xfs: fixes for 3.15-rc6

[Dave Chinner]

On Thu, May 15, 2014 at 10:53:20PM -0700, Christoph Hellwig wrote:
> On Fri, May 16, 2014 at 12:11:44PM +1000, Dave Chinner wrote:
> > Hi Linus,
> > 
> > Can you please pull the updates listed below? I found a bunch of
> > error sign issues while determine what we need to do to rid XFS of
> > this problem permanently. A couple of the bugs are in data integirty
> > operations, a couple more are in the new COLLAPSE_RANGE code. One of
> > these came in through a recent ext4 merge and so I had to update the
> > base tree to 3.15-rc5 before fixing the issues.
> 
> Doesn't this miss the log roundin fix?

I'm still verifying/testing that fix (a several day stress
test was need to uncover it in the first place). It will need to be pushed back to
the -stable kernels, anyway, so it doesn't really matter which
kernel it goes into as long as it has the cc: stable tag in it...

> Linus said he is away for about a weeke anyway, while we're at it.

I missed that. Not a big problem, I'll just resend the pull request
when he gets back...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs