From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/5] xfs: turn NLINK feature on by default
Date: Sat, 17 May 2014 04:54:25 -0700 [thread overview]
Message-ID: <20140517115425.GA10470@infradead.org> (raw)
In-Reply-To: <1400281252-29638-4-git-send-email-david@fromorbit.com>
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index 944f3d9..3f09782 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -697,6 +697,12 @@ xfs_mountfs(
> mp->m_update_flags |= XFS_SB_VERSIONNUM;
> }
>
> + /* always use v2 inodes by default now */
> + if (!(mp->m_sb.sb_versionnum & XFS_SB_VERSION_NLINKBIT)) {
> + mp->m_sb.sb_versionnum |= XFS_SB_VERSION_NLINKBIT;
> + mp->m_update_flags |= XFS_SB_VERSIONNUM;
> + }
This probably should print a message for the user.
Otherwise looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-17 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 23:00 [PATCH 0/5 V2] xfs: sanitise superblock feature bit support Dave Chinner
2014-05-16 23:00 ` [PATCH 1/5] xfs: make superblock version checks reflect reality Dave Chinner
2014-05-16 23:00 ` [PATCH 2/5] xfs: keep sb_bad_features2 the same a sb_features2 Dave Chinner
2014-05-16 23:00 ` [PATCH 3/5] xfs: turn NLINK feature on by default Dave Chinner
2014-05-17 11:54 ` Christoph Hellwig [this message]
2014-05-16 23:00 ` [PATCH 4/5] xfs: don't need dirv2 checks anymore Dave Chinner
2014-05-16 23:00 ` [PATCH 5/5] xfs: remove shared supberlock feature checking Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2014-05-06 3:55 [PATCH 0/5] xfs: sanitise supberlock feature bit support Dave Chinner
2014-05-06 3:55 ` [PATCH 3/5] xfs: turn NLINK feature on by default Dave Chinner
2014-05-06 8:15 ` Christoph Hellwig
2014-05-06 9:06 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140517115425.GA10470@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox