From: Dave Chinner <david@fromorbit.com>
To: Roger Willcocks <roger@filmlight.ltd.uk>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix compile error when libxfs header used in C++ code
Date: Tue, 20 May 2014 08:59:44 +1000 [thread overview]
Message-ID: <20140519225944.GF8554@dastard> (raw)
In-Reply-To: <3EEEF4AD-A192-4A5B-A81A-5FC38F5CF95F@filmlight.ltd.uk>
On Mon, May 12, 2014 at 06:52:34PM +0100, Roger Willcocks wrote:
> xfs_ialloc.h:102: error: expected ‘,’ or ‘...’ before ‘delete'
>
> Simple parameter rename, no changes to behaviour.
>
> Signed-off-by: Roger Willcocks <roger@filmlight.ltd.uk>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
The merge into the for-next branch conflicted with the finobt
changes, but I think I cleaned that up fine.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-19 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 15:22 'delete' parameter in xfs_ialloc.h Roger Willcocks
2014-05-12 15:31 ` Eric Sandeen
2014-05-12 17:52 ` Roger Willcocks
2014-05-12 17:52 ` [PATCH] xfsprogs: fix compile error when libxfs header used in C++ code Roger Willcocks
2014-05-12 17:52 ` [PATCH] xfs: " Roger Willcocks
2014-05-19 22:59 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519225944.GF8554@dastard \
--to=david@fromorbit.com \
--cc=roger@filmlight.ltd.uk \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox