From: Brian Foster <bfoster@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/005: filter _scratch_mount output and fix golden output to match it
Date: Thu, 22 May 2014 13:06:48 -0400 [thread overview]
Message-ID: <20140522170647.GA25877@bfoster.bfoster> (raw)
In-Reply-To: <1400775429-30015-1-git-send-email-eguan@redhat.com>
On Fri, May 23, 2014 at 12:17:09AM +0800, Eryu Guan wrote:
> Failure message of _scratch_mount is something like:
>
> mount: mount /dev/sda5 on /mnt/scratch failed: Structure needs cleaning
>
> not
>
> mount: Structure needs cleaning
>
> Filter the output and fix the golden image to match the new output.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> tests/xfs/005 | 2 +-
> tests/xfs/005.out | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/xfs/005 b/tests/xfs/005
> index 94157c4..534f910 100755
> --- a/tests/xfs/005
> +++ b/tests/xfs/005
> @@ -59,7 +59,7 @@ _scratch_mkfs_xfs -m crc=1 >> $seqres.full 2>&1 || _fail "mkfs failed"
> $XFS_IO_PROG -c "pwrite 224 4" $SCRATCH_DEV | _filter_xfs_io
>
> # should FAIL, the crc is bad; golden output contains mount failure
> -_scratch_mount
> +_scratch_mount 2>&1 | _filter_scratch
>
> # success, all done
> status=0
> diff --git a/tests/xfs/005.out b/tests/xfs/005.out
> index 13d0125..853e446 100644
> --- a/tests/xfs/005.out
> +++ b/tests/xfs/005.out
> @@ -1,4 +1,4 @@
> QA output created by 005
> wrote 4/4 bytes at offset 224
> XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -mount: Structure needs cleaning
> +mount: mount SCRATCH_DEV on SCRATCH_MNT failed: Structure needs cleaning
> --
> 1.9.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-22 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 16:17 [PATCH] xfs/005: filter _scratch_mount output and fix golden output to match it Eryu Guan
2014-05-22 17:06 ` Brian Foster [this message]
2014-05-22 23:34 ` Dave Chinner
2014-05-23 3:17 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522170647.GA25877@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox