From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Plamen Petrov <plamen.sisi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, sandeen@redhat.com
Subject: Re: [PATCH] do_mounts: try all available filesystems before panicking
Date: Mon, 26 May 2014 12:40:51 +1000 [thread overview]
Message-ID: <20140526024051.GU8554@dastard> (raw)
In-Reply-To: <20140525211129.GA5243@thunk.org>
On Sun, May 25, 2014 at 05:11:30PM -0400, Theodore Ts'o wrote:
> On Sun, May 25, 2014 at 01:04:09PM -0700, Linus Torvalds wrote:
> >
> > The fact is, I think xfs is just buggy. Returning 38 (ENOSYS) is
> > totally insane. "No such system call"? Somebody is on some bad bad
> > drugs. Not that the mount_block_root() loop and error handling might
> > not be a good thing to perhaps tweak _too_, but at the very least your
> > patch means that now it no longer prints out the error number at all.
>
> There's only a single instance of ENOSYS in fs/xfs/xfs_mount.c:
>
> /*
> * We must be able to do sector-sized and sector-aligned IO.
> */
> if (sector_size > sbp->sb_sectsize) {
> if (loud)
> xfs_warn(mp, "device supports %u byte sectors (not %u)",
> sector_size, sbp->sb_sectsize);
> error = ENOSYS;
> goto release_buf;
> }
>
> Plamen, does changing the ENOSYS to EINVAL above fix things for you?
>
> > Anyway, I'm also not seeing why that xfs error would be new to 3.14,
> > though.. Adding the XFS people to the cc.
>
> If I had to guess, commit daba5427d is new to 3.14, and it might
> explain the change in behavior.
Yup, it's buggy, though not in an obvious way. I'll have a patch for
it soon.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-26 2:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1399314889-9829-1-git-send-email-plamen.sisi@gmail.com>
2014-05-25 20:04 ` [PATCH] do_mounts: try all available filesystems before panicking Linus Torvalds
2014-05-25 21:11 ` Theodore Ts'o
2014-05-26 2:40 ` Dave Chinner [this message]
2014-05-26 0:08 ` Dave Chinner
2014-05-26 1:19 ` Dave Chinner
2014-05-26 4:19 ` Dave Chinner
2014-05-26 5:18 ` Пламен Петров
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526024051.GU8554@dastard \
--to=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plamen.sisi@gmail.com \
--cc=sandeen@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox