From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs; fix xfs_da_args sparse warning in xfs_readdir
Date: Fri, 6 Jun 2014 13:33:54 -0400 [thread overview]
Message-ID: <20140606173353.GC3048@laptop.bfoster> (raw)
In-Reply-To: <1402042701-26173-1-git-send-email-david@fromorbit.com>
On Fri, Jun 06, 2014 at 06:18:21PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The kbuild test robot reported:
>
> >> fs/xfs/xfs_dir2_readdir.c:672:41: sparse: Using plain integer as NULL pointer
>
> Fix it.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_dir2_readdir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_dir2_readdir.c b/fs/xfs/xfs_dir2_readdir.c
> index ca1f43c..48e99af 100644
> --- a/fs/xfs/xfs_dir2_readdir.c
> +++ b/fs/xfs/xfs_dir2_readdir.c
> @@ -669,7 +669,7 @@ xfs_readdir(
> struct dir_context *ctx,
> size_t bufsize)
> {
> - struct xfs_da_args args = {0};
> + struct xfs_da_args args = { NULL };
> int rval;
> int v;
> uint lock_mode;
> --
> 2.0.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-06-06 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 8:18 [PATCH] xfs; fix xfs_da_args sparse warning in xfs_readdir Dave Chinner
2014-06-06 17:33 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606173353.GC3048@laptop.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox