From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [DISCUSS] Planning for new dev cycle (3.17)
Date: Wed, 11 Jun 2014 07:54:20 +1000 [thread overview]
Message-ID: <20140610215420.GI9508@dastard> (raw)
In-Reply-To: <53971184.50008@sandeen.net>
On Tue, Jun 10, 2014 at 09:09:08AM -0500, Eric Sandeen wrote:
> On 6/10/14, 1:09 AM, Dave Chinner wrote:
>
> > There is a new version of this work (Eric's patches and the base
> > libxfs restructure) here:
> >
> > git://oss.sgi.com/xfs/xfs.git xfs-libxfs-restructure
> >
> > It's based on 3.15 with the current for-next branch merged into it
> > and then the changes done over the top, so it's about as up-to-date
> > as it can be. Comments welcome...
>
> Comment 1: doesn't build ;)
>
>
> make[1]: *** No rule to make target `fs/xfs/xfs_dir2_readdir.o', needed by `fs/xfs/xfs.o'. Stop.
> make[1]: *** Waiting for unfinished jobs....
> CC [M] fs/xfs/xfs_buf.o
> make: *** [_module_fs/xfs] Error 2
Ah, that's an issue....
> problems w/ xfs_rtbitmap.o as well, patch follows.
>
> Comment 2: Coverity thinks this adds about 25 defects, I'll have to go
> look at why...
Probably because it ignores issues based on path/filename, and the
path changed...
>
> -Eric
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index a22a6b8..0b7b3b3 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -43,6 +43,7 @@ xfs-y += $(addprefix libxfs/, \
> xfs_dir2_data.o \
> xfs_dir2_leaf.o \
> xfs_dir2_node.o \
> + xfs_dir2_readdir.o \
No, the xfs_dir2_readdir.c file should not have been moved - it's
kernel only functionality.
> xfs_dir2_sf.o \
> xfs_dquot_buf.o \
> xfs_ialloc.o \
> @@ -55,6 +56,9 @@ xfs-y += $(addprefix libxfs/, \
> xfs_trans_resv.o \
> )
>
> +xfs-$(CONFIG_XFS_RT) += $(addprefix libxfs/, \
> + xfs_rtbitmap.o \
> + )
But that needs fixing, yes.
Makes me wonder why it linked here - must have found stale .o files
in the build area and linked them even though the files didn't get
built.
Anyway, I'll fix it, and restart the errno negation rebase....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-06-10 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 22:33 [DISCUSS] Planning for new dev cycle (3.17) Dave Chinner
2014-06-10 6:09 ` Dave Chinner
2014-06-10 14:09 ` Eric Sandeen
2014-06-10 21:54 ` Dave Chinner [this message]
2014-06-10 21:57 ` Eric Sandeen
2014-06-10 11:58 ` Brian Foster
2014-06-10 21:48 ` Dave Chinner
2014-06-11 9:10 ` Dave Chinner
2014-06-12 20:01 ` Brian Foster
2014-06-12 23:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610215420.GI9508@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox