public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [XFS updates] XFS development tree branch, xfs-libxfs-restructure, updated. xfs-for-linus-3.16-rc1-13107-gc59a5ac
@ 2014-06-23  7:23 xfs
  2014-06-23  8:06 ` Dave Chinner
  0 siblings, 1 reply; 4+ messages in thread
From: xfs @ 2014-06-23  7:23 UTC (permalink / raw)
  To: xfs

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, xfs-libxfs-restructure has been updated
  discards  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)
  discards  e3584e38615389850684fcffd699d97e2e06f2d6 (commit)
  discards  f212d6fcf5c1cc3a3980dd320804c1dfb9f49b75 (commit)
  discards  e10404cf914273de8016d5992c7049bdb9a9a089 (commit)
  discards  f3a19b3ad85dcc4a073270e1fb594eff37709788 (commit)
  discards  d5a6cda3cf2c0860543db26bb5df7ed4404f74cd (commit)
  c59a5ac xfs: global error sign conversion
  63d512e libxfs: move source files
  547a71f libxfs: move header files
  62c9454 xfs: create libxfs infrastructure
  b474c7a xfs: Nuke XFS_ERROR macro
  d99831f xfs: return is not a function
  16b9057 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
  9c1d528 Merge commit '9f12600fe425bc28f0ccba034a77783c09c15af4' into for-linus
  8d02076 ->splice_write() via ->write_iter()
  412dd3a Merge tag 'xfs-for-linus-3.16-rc1' of git://oss.sgi.com/xfs/xfs
  23adbe1 fs,userns: Change inode_capable to capable_wrt_inode_uidgid
  bf97f3b xfs: switch to ->write_iter()
  b4f5d2c xfs: switch to ->read_iter()
  b318891 xfs: trim the argument lists of xfs_file_{dio,buffered}_aio_write()
  0c94933 iov_iter_truncate()
  71d8e53 start adding the tag to iov_iter
  31b1403 switch {__,}blockdev_direct_IO() to iov_iter
  a6cbcd4 get rid of pointless iov_length() in ->direct_IO()
  d8d3d94 pass iov_iter to ->direct_IO()
  cb66a7a kill generic_segment_checks()
  f8579f8 generic_file_direct_write(): switch to iov_iter
      from  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c59a5aca071806ce2ed7279bbaf78336da49ce85
Author: Dave Chinner <dchinner@redhat.com>
Date:   Mon Jun 23 16:50:54 2014 +1000

    xfs: global error sign conversion
    
    Convert all the errors the core XFs code to negative error signs
    like the rest of the kernel and remove all the sign conversion we
    do in the interface layers.
    
    Errors for conversion (and comparison) found via searches like:
    
    $ git grep " E" fs/xfs
    $ git grep "return E" fs/xfs
    $ git grep " E[A-Z].*;$" fs/xfs
    
    Negation points found via searches like:
    
    $ git grep "= -[a-z,A-Z]" fs/xfs
    $ git grep "return -[a-z,A-D,F-Z]" fs/xfs
    $ git grep " -[a-z].*;" fs/xfs
    
    [ with some bits I missed from Brian Foster ]
    
    Signed-off-by: Dave Chinner <dchinner@redhat.com>

commit 63d512e1df8acffc3aa0068c6efab100c623968f
Author: Dave Chinner <dchinner@redhat.com>
Date:   Sun Jun 22 15:07:54 2014 +1000

    libxfs: move source files
    
    Move all the source files that are shared with userspace into
    libxfs/. This is done as one big chunk simpy to get it done
    quickly
    
    Signed-off-by: Dave Chinner <dchinner@redhat.com>

commit 547a71f18113e33ff2420ad8b1712c6ab497a1dc
Author: Dave Chinner <dchinner@redhat.com>
Date:   Sun Jun 22 15:06:54 2014 +1000

    libxfs: move header files
    
    Move all the header files that are shared with userspace into
    libxfs. This is done as one big chunk simpy to get it done quickly.
    
    Signed-off-by: Dave Chinner <dchinner@redhat.com>

commit 62c94547670f715923950a326daf8b129ca05ee5
Author: Dave Chinner <dchinner@redhat.com>
Date:   Sun Jun 22 15:05:54 2014 +1000

    xfs: create libxfs infrastructure
    
    To minimise the differences between kernel and userspace code,
    split the kernel code into the same structure as the userspace code.
    That is, the gneric core functionality of XFS is moved to a libxfs/
    directory and treat it as a layering barrier in the XFS code.
    
    This patch introduces the libxfs directory, the build infrastructure
    and an initial source and header file to build. The libxfs directory
    will contain the header files that are needed to build libxfs - most
    of userspace does not care about the location of these header files
    as they are accessed indirectly. Hence keeping them inside libxfs
    makes it easy to track the changes and script the sync process as
    the directory structure will be identical.
    
    To allow this changeover to occur in the kernel code, there are some
    temporary infrastructure in the makefiles to grab the header
    filesystem from both locations. Once all the files are moved,
    modifications will be made in the source code that will make the
    need for these include directives go away.
    
    Signed-off-by: Dave Chinner <dchinner@redhat.com>

commit b474c7ae4395ba684e85fde8f55c8cf44a39afaf
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Sun Jun 22 15:04:54 2014 +1000

    xfs: Nuke XFS_ERROR macro
    
    XFS_ERROR was designed long ago to trap return values, but it's not
    runtime configurable, it's not consistently used, and we can do
    similar error trapping with ftrace scripts and triggers from
    userspace.
    
    Just nuke XFS_ERROR and associated bits.
    
    Signed-off-by: Eric Sandeen <sandeen@redhat.com>
    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    Signed-off-by: Dave Chinner <david@fromorbit.com>

commit d99831ff393ff2e28d6110b41f24d9fecf986222
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Sun Jun 22 15:03:54 2014 +1000

    xfs: return is not a function
    
    return is not a function.  "return(EIO);" is silly;
    "return (EIO);" moreso.  return is not a function.
    Nuke the pointless parens.
    
    [dchinner: catch a couple of extra cases in xfs_attr_list.c,
    xfs_acl.c and xfs_linux.h.]
    
    Signed-off-by: Eric Sandeen <sandeen@redhat.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    Signed-off-by: Dave Chinner <david@fromorbit.com>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/xfs_aops.c      |  17 +++----
 fs/xfs/xfs_attr_list.c |   2 +-
 fs/xfs/xfs_file.c      | 119 +++++++++++--------------------------------------
 fs/xfs/xfs_ioctl.c     |   2 +-
 fs/xfs/xfs_ioctl32.c   |   4 +-
 fs/xfs/xfs_trace.h     |   1 -
 6 files changed, 38 insertions(+), 107 deletions(-)


hooks/post-receive
-- 
XFS development tree

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [XFS updates] XFS development tree branch, xfs-libxfs-restructure, updated. xfs-for-linus-3.16-rc1-13107-gc59a5ac
  2014-06-23  7:23 [XFS updates] XFS development tree branch, xfs-libxfs-restructure, updated. xfs-for-linus-3.16-rc1-13107-gc59a5ac xfs
@ 2014-06-23  8:06 ` Dave Chinner
  2014-06-24 14:25   ` Brian Foster
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Chinner @ 2014-06-23  8:06 UTC (permalink / raw)
  To: xfs

On Mon, Jun 23, 2014 at 02:23:59AM -0500, xfs@oss.sgi.com wrote:
> This is an automated email from the git hooks/post-receive script. It was
> generated because a ref change was pushed to the repository containing
> the project "XFS development tree".
> 
> The branch, xfs-libxfs-restructure has been updated
>   discards  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)
>   discards  e3584e38615389850684fcffd699d97e2e06f2d6 (commit)
>   discards  f212d6fcf5c1cc3a3980dd320804c1dfb9f49b75 (commit)
>   discards  e10404cf914273de8016d5992c7049bdb9a9a089 (commit)
>   discards  f3a19b3ad85dcc4a073270e1fb594eff37709788 (commit)
>   discards  d5a6cda3cf2c0860543db26bb5df7ed4404f74cd (commit)
>   c59a5ac xfs: global error sign conversion
>   63d512e libxfs: move source files
>   547a71f libxfs: move header files
>   62c9454 xfs: create libxfs infrastructure
>   b474c7a xfs: Nuke XFS_ERROR macro
>   d99831f xfs: return is not a function
>   16b9057 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
>   9c1d528 Merge commit '9f12600fe425bc28f0ccba034a77783c09c15af4' into for-linus
>   8d02076 ->splice_write() via ->write_iter()
>   412dd3a Merge tag 'xfs-for-linus-3.16-rc1' of git://oss.sgi.com/xfs/xfs
>   23adbe1 fs,userns: Change inode_capable to capable_wrt_inode_uidgid
>   bf97f3b xfs: switch to ->write_iter()
>   b4f5d2c xfs: switch to ->read_iter()
>   b318891 xfs: trim the argument lists of xfs_file_{dio,buffered}_aio_write()
>   0c94933 iov_iter_truncate()
>   71d8e53 start adding the tag to iov_iter
>   31b1403 switch {__,}blockdev_direct_IO() to iov_iter
>   a6cbcd4 get rid of pointless iov_length() in ->direct_IO()
>   d8d3d94 pass iov_iter to ->direct_IO()
>   cb66a7a kill generic_segment_checks()
>   f8579f8 generic_file_direct_write(): switch to iov_iter
>       from  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)
> 
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email; so we list those
> revisions in full, below.

This looks like a lot of non-libxfs changes, but it's mostly just
noise from the rebase from 3.15.0 to the current master branch at
3.16-rc2.

I've added all the negation fixes that Brian noted, and tested all
the different config options (m,y,n) for the libxfs restructure. I
haven't come across any problems over the weekend, so I'd like to
push this out so that we can get this dev cycle properly underway.
If people can ack this, I'll add all the appropriate sign-offs and
push it.

Once that is done, I'll start pulling in all the outstanding
patchsets and work through getting them through reviews and
into for-next....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [XFS updates] XFS development tree branch, xfs-libxfs-restructure, updated. xfs-for-linus-3.16-rc1-13107-gc59a5ac
  2014-06-23  8:06 ` Dave Chinner
@ 2014-06-24 14:25   ` Brian Foster
  2014-06-24 19:59     ` Dave Chinner
  0 siblings, 1 reply; 4+ messages in thread
From: Brian Foster @ 2014-06-24 14:25 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs

On Mon, Jun 23, 2014 at 06:06:18PM +1000, Dave Chinner wrote:
> On Mon, Jun 23, 2014 at 02:23:59AM -0500, xfs@oss.sgi.com wrote:
> > This is an automated email from the git hooks/post-receive script. It was
> > generated because a ref change was pushed to the repository containing
> > the project "XFS development tree".
> > 
> > The branch, xfs-libxfs-restructure has been updated
> >   discards  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)
> >   discards  e3584e38615389850684fcffd699d97e2e06f2d6 (commit)
> >   discards  f212d6fcf5c1cc3a3980dd320804c1dfb9f49b75 (commit)
> >   discards  e10404cf914273de8016d5992c7049bdb9a9a089 (commit)
> >   discards  f3a19b3ad85dcc4a073270e1fb594eff37709788 (commit)
> >   discards  d5a6cda3cf2c0860543db26bb5df7ed4404f74cd (commit)
> >   c59a5ac xfs: global error sign conversion
> >   63d512e libxfs: move source files
> >   547a71f libxfs: move header files
> >   62c9454 xfs: create libxfs infrastructure
> >   b474c7a xfs: Nuke XFS_ERROR macro
> >   d99831f xfs: return is not a function
> >   16b9057 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
> >   9c1d528 Merge commit '9f12600fe425bc28f0ccba034a77783c09c15af4' into for-linus
> >   8d02076 ->splice_write() via ->write_iter()
> >   412dd3a Merge tag 'xfs-for-linus-3.16-rc1' of git://oss.sgi.com/xfs/xfs
> >   23adbe1 fs,userns: Change inode_capable to capable_wrt_inode_uidgid
> >   bf97f3b xfs: switch to ->write_iter()
> >   b4f5d2c xfs: switch to ->read_iter()
> >   b318891 xfs: trim the argument lists of xfs_file_{dio,buffered}_aio_write()
> >   0c94933 iov_iter_truncate()
> >   71d8e53 start adding the tag to iov_iter
> >   31b1403 switch {__,}blockdev_direct_IO() to iov_iter
> >   a6cbcd4 get rid of pointless iov_length() in ->direct_IO()
> >   d8d3d94 pass iov_iter to ->direct_IO()
> >   cb66a7a kill generic_segment_checks()
> >   f8579f8 generic_file_direct_write(): switch to iov_iter
> >       from  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)
> > 
> > Those revisions listed above that are new to this repository have
> > not appeared on any other notification email; so we list those
> > revisions in full, below.
> 
> This looks like a lot of non-libxfs changes, but it's mostly just
> noise from the rebase from 3.15.0 to the current master branch at
> 3.16-rc2.
> 
> I've added all the negation fixes that Brian noted, and tested all
> the different config options (m,y,n) for the libxfs restructure. I
> haven't come across any problems over the weekend, so I'd like to
> push this out so that we can get this dev cycle properly underway.
> If people can ack this, I'll add all the appropriate sign-offs and
> push it.
> 

The changes look good to me and I don't see any failures that aren't
common with for-next, so:

Reviewed-by: Brian Foster <bfoster@redhat.com>

That said, I am seeing a BUG() on for-next kernels via repeated xfs/297
runs. Output is appended below.

Brian

------------[ cut here ]------------
kernel BUG at fs/xfs/xfs_aops.c:1373!
invalid opcode: 0000 [#1] SMP 
Modules linked in: xfs(OE) libcrc32c sunrpc ipt_REJECT nf_conntrack_ipv4 nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables binfmt_misc ipmi_si ipmi_msghandler acpi_power_meter dcdbas pcspkr serio_raw ixgbe dca ptp pps_core mdio ses enclosure amd64_edac_mod edac_core edac_mce_amd k10temp sp5100_tco i2c_piix4 sg bnx2 ext4(E) jbd2(E) mbcache(E) sr_mod(E) cdrom(E) sd_mod(E) crc_t10dif(E) crct10dif_common(E) megaraid_sas(E) mpt2sas(E) scsi_transport_sas(E) raid_class(E) usb_storage(E) mgag200(E) ttm(E) drm_kms_helper(E) drm(E) i2c_algo_bit(E) sysimgblt(E) sysfillrect(E) i2c_core(E) syscopyarea(E) dm_mirror(E) dm_region_hash(E) dm_log(E) dm_mod(E) [last unloaded: xfs]
CPU: 10 PID: 14202 Comm: fsstress Tainted: G           OE 3.16.0-rc2+ #5
Hardware name: Dell Inc. PowerEdge R715/0G2DP3, BIOS 2.3.0 10/18/2011
task: ffff88061c47d880 ti: ffff88061c4dc000 task.ti: ffff88061c4dc000
RIP: 0010:[<ffffffffa04f79d8>]  [<ffffffffa04f79d8>] __xfs_get_blocks+0x548/0x550 [xfs]
RSP: 0018:ffff88061c4df918  EFLAGS: 00010202
RAX: ffff8808347c8680 RBX: ffff88062cac5b08 RCX: 0000000000000200
RDX: 0000000000000001 RSI: 0000000000000008 RDI: ffff88062cac5b08
RBP: ffff88061c4df9a8 R08: 00000000000001a3 R09: ffff88061c4df8cc
R10: 00007fc884019000 R11: 0000000000000000 R12: 000000000018a000
R13: ffff88061c4dfbc8 R14: ffff8800b213e800 R15: 0000000000019000
FS:  00007fc88be5b700(0000) GS:ffff880437c20000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 0000003a6dd92448 CR3: 000000063152d000 CR4: 00000000000006e0
Stack:
 ffff88061c4df938 00007fc884018fff 01ff880600000000 0000000100000008
 000000000000018a ffff88062cac5940 0000000000000179 ffffffffffffffff
 0000000000000087 ffffffff00000000 0000000000000009 000000011c3e6e28
Call Trace:
 [<ffffffffa04f79f4>] xfs_get_blocks_direct+0x14/0x20 [xfs]
 [<ffffffff81220b3b>] do_direct_IO+0x1cb/0x1100
 [<ffffffff81221bc3>] ? do_blockdev_direct_IO+0x153/0xc00
 [<ffffffff81221e01>] do_blockdev_direct_IO+0x391/0xc00
 [<ffffffff8117cd25>] ? pagevec_lookup_tag+0x25/0x40
 [<ffffffff8117a94f>] ? write_cache_pages+0x12f/0x4c0
 [<ffffffffa04f79e0>] ? __xfs_get_blocks+0x550/0x550 [xfs]
 [<ffffffff8117ad3c>] ? generic_writepages+0x5c/0x80
 [<ffffffff812226bc>] __blockdev_direct_IO+0x4c/0x50
 [<ffffffffa04f79e0>] ? __xfs_get_blocks+0x550/0x550 [xfs]
 [<ffffffffa04f7216>] xfs_vm_direct_IO+0x136/0x140 [xfs]
 [<ffffffffa04f79e0>] ? __xfs_get_blocks+0x550/0x550 [xfs]
 [<ffffffff81170d63>] generic_file_read_iter+0x143/0x150
 [<ffffffffa050457a>] xfs_file_read_iter+0x12a/0x280 [xfs]
 [<ffffffff811e6e3f>] new_sync_read+0x8f/0xc0
 [<ffffffff811e7343>] vfs_read+0xa3/0x110
 [<ffffffff812043a3>] ? __fdget+0x13/0x20
 [<ffffffff811e7906>] SyS_read+0x56/0xd0
 [<ffffffff8164ada9>] system_call_fastpath+0x16/0x1b
Code: 00 00 00 f7 d8 e9 51 fd ff ff 66 0f 1f 84 00 00 00 00 00 80 7d 87 00 74 0a 49 89 5d 40 f0 41 80 4d 02 01 f0 41 80 4d 01 10 eb c0 <0f> 0b eb fe 0f 1f 40 00 55 48 89 e5 66 66 66 66 90 41 b8 01 00 
RIP  [<ffffffffa04f79d8>] __xfs_get_blocks+0x548/0x550 [xfs]
 RSP <ffff88061c4df918>
---[ end trace ef315dcf69ea8a1f ]---

> Once that is done, I'll start pulling in all the outstanding
> patchsets and work through getting them through reviews and
> into for-next....
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [XFS updates] XFS development tree branch, xfs-libxfs-restructure, updated. xfs-for-linus-3.16-rc1-13107-gc59a5ac
  2014-06-24 14:25   ` Brian Foster
@ 2014-06-24 19:59     ` Dave Chinner
  0 siblings, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2014-06-24 19:59 UTC (permalink / raw)
  To: Brian Foster; +Cc: xfs

On Tue, Jun 24, 2014 at 10:25:36AM -0400, Brian Foster wrote:
> On Mon, Jun 23, 2014 at 06:06:18PM +1000, Dave Chinner wrote:
> > On Mon, Jun 23, 2014 at 02:23:59AM -0500, xfs@oss.sgi.com wrote:
> > > This is an automated email from the git hooks/post-receive script. It was
> > > generated because a ref change was pushed to the repository containing
> > > the project "XFS development tree".
> > > 
> > > The branch, xfs-libxfs-restructure has been updated
> > >   discards  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)
> > >   discards  e3584e38615389850684fcffd699d97e2e06f2d6 (commit)
> > >   discards  f212d6fcf5c1cc3a3980dd320804c1dfb9f49b75 (commit)
> > >   discards  e10404cf914273de8016d5992c7049bdb9a9a089 (commit)
> > >   discards  f3a19b3ad85dcc4a073270e1fb594eff37709788 (commit)
> > >   discards  d5a6cda3cf2c0860543db26bb5df7ed4404f74cd (commit)
> > >   c59a5ac xfs: global error sign conversion
> > >   63d512e libxfs: move source files
> > >   547a71f libxfs: move header files
> > >   62c9454 xfs: create libxfs infrastructure
> > >   b474c7a xfs: Nuke XFS_ERROR macro
> > >   d99831f xfs: return is not a function
> > >   16b9057 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
> > >   9c1d528 Merge commit '9f12600fe425bc28f0ccba034a77783c09c15af4' into for-linus
> > >   8d02076 ->splice_write() via ->write_iter()
> > >   412dd3a Merge tag 'xfs-for-linus-3.16-rc1' of git://oss.sgi.com/xfs/xfs
> > >   23adbe1 fs,userns: Change inode_capable to capable_wrt_inode_uidgid
> > >   bf97f3b xfs: switch to ->write_iter()
> > >   b4f5d2c xfs: switch to ->read_iter()
> > >   b318891 xfs: trim the argument lists of xfs_file_{dio,buffered}_aio_write()
> > >   0c94933 iov_iter_truncate()
> > >   71d8e53 start adding the tag to iov_iter
> > >   31b1403 switch {__,}blockdev_direct_IO() to iov_iter
> > >   a6cbcd4 get rid of pointless iov_length() in ->direct_IO()
> > >   d8d3d94 pass iov_iter to ->direct_IO()
> > >   cb66a7a kill generic_segment_checks()
> > >   f8579f8 generic_file_direct_write(): switch to iov_iter
> > >       from  fcec2eb6a31bde491f4ce9ddd94b41c8aacccd43 (commit)
> > > 
> > > Those revisions listed above that are new to this repository have
> > > not appeared on any other notification email; so we list those
> > > revisions in full, below.
> > 
> > This looks like a lot of non-libxfs changes, but it's mostly just
> > noise from the rebase from 3.15.0 to the current master branch at
> > 3.16-rc2.
> > 
> > I've added all the negation fixes that Brian noted, and tested all
> > the different config options (m,y,n) for the libxfs restructure. I
> > haven't come across any problems over the weekend, so I'd like to
> > push this out so that we can get this dev cycle properly underway.
> > If people can ack this, I'll add all the appropriate sign-offs and
> > push it.
> > 
> 
> The changes look good to me and I don't see any failures that aren't
> common with for-next, so:
> 
> Reviewed-by: Brian Foster <bfoster@redhat.com>

Thanks, Brian.

> That said, I am seeing a BUG() on for-next kernels via repeated xfs/297
> runs. Output is appended below.

Yup, I'm still seeing those stale delalloc block asserts quite
regularly. There was a lull after the last round of fixes I did, but
in the last couple of months they've beena regular occurrence in my
testing again...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-06-24 19:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-23  7:23 [XFS updates] XFS development tree branch, xfs-libxfs-restructure, updated. xfs-for-linus-3.16-rc1-13107-gc59a5ac xfs
2014-06-23  8:06 ` Dave Chinner
2014-06-24 14:25   ` Brian Foster
2014-06-24 19:59     ` Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox