From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id A02FA7F66 for ; Wed, 25 Jun 2014 23:10:43 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 556E78F804C for ; Wed, 25 Jun 2014 21:10:40 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id Ya2ewsLDszcqiBny for ; Wed, 25 Jun 2014 21:10:37 -0700 (PDT) Date: Thu, 26 Jun 2014 14:10:03 +1000 From: Dave Chinner Subject: Re: [PATCH 1/6] xfs: fix a couple error sequence jumps in xfs_mountfs() Message-ID: <20140626041003.GU4453@dastard> References: <1402060414-22075-1-git-send-email-bfoster@redhat.com> <1402060414-22075-2-git-send-email-bfoster@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1402060414-22075-2-git-send-email-bfoster@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: xfs@oss.sgi.com On Fri, Jun 06, 2014 at 09:13:29AM -0400, Brian Foster wrote: > xfs_mountfs() has a couple failure conditions that do not jump to the > correct labels. Specifically: > > - xfs_initialize_perag_data() failure does not deallocate the log even > though it occurs after log initialization > - xfs_mount_reset_sbqflags() failure returns the error directly rather > than jump to the error sequence > > Signed-off-by: Brian Foster Looks good. Reviewed-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs