From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/6] xfs: document log sysfs attributes in testing ABI
Date: Thu, 26 Jun 2014 15:03:45 +1000 [thread overview]
Message-ID: <20140626050345.GZ4453@dastard> (raw)
In-Reply-To: <1402060414-22075-7-git-send-email-bfoster@redhat.com>
On Fri, Jun 06, 2014 at 09:13:34AM -0400, Brian Foster wrote:
> Create a sysfs-fs-xfs ABI documentation file for newly added sysfs
> attributes. This is created under the testing section.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks fine, but I'm not sure we ever want people to think these are
going to form part of the stable XFS ABI - they are encodings of
deeply internal functionality of XFS. We're not going to be tied to
an implementation because of diagnostic information we expose to
to sysfs, so users need to know that this is a volatile interface.
Hence I'd suggest adding a disclaimer indicating that these not ever
guaranteed to be stable and could change or be removed at any time
without warning. Say, for example, we add another description line
like this:
Stability: Volatile
We can then point out the entries that are we'll never guarantee are
stable, those that we are stabilising, and those that are considered
stable easily?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-06-26 5:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 13:13 [PATCH 0/6] xfs sysfs support Brian Foster
2014-06-06 13:13 ` [PATCH 1/6] xfs: fix a couple error sequence jumps in xfs_mountfs() Brian Foster
2014-06-26 4:10 ` Dave Chinner
2014-06-06 13:13 ` [PATCH 2/6] xfs: add a sysfs kset Brian Foster
2014-06-26 4:13 ` Dave Chinner
2014-06-06 13:13 ` [PATCH 3/6] xfs: add xfs_mount sysfs kobject Brian Foster
2014-06-26 4:29 ` Dave Chinner
2014-06-06 13:13 ` [PATCH 4/6] xfs: add xlog sysfs kobject and attribute handlers Brian Foster
2014-06-26 4:47 ` Dave Chinner
2014-06-26 12:28 ` Brian Foster
2014-06-26 13:41 ` Brian Foster
2014-06-06 13:13 ` [PATCH 5/6] xfs: add log attributes for log lsn and grant head data Brian Foster
2014-06-26 4:52 ` Dave Chinner
2014-06-26 12:29 ` Brian Foster
2014-06-06 13:13 ` [PATCH 6/6] xfs: document log sysfs attributes in testing ABI Brian Foster
2014-06-26 5:03 ` Dave Chinner [this message]
2014-06-26 12:30 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626050345.GZ4453@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox