From: "Arkadiusz Miśkiewicz" <arekm@maven.pl>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] repair: get rid of BADFSINO
Date: Tue, 1 Jul 2014 15:43:49 +0200 [thread overview]
Message-ID: <201407011543.49828.arekm@maven.pl> (raw)
In-Reply-To: <1404219296-29302-5-git-send-email-david@fromorbit.com>
On Tuesday 01 of July 2014, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> so get rid of BADFSINO and only use the name junking to mark
> dirents as bad. This prevents the directory data block verifier from
> triggering on bad inode numbers, and so the later reread of the
> block will find the junked entries correctly.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> repair/dir2.c | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
> @@ -1427,11 +1419,11 @@ _("entry at block %u offset %" PRIdPTR " in
> directory inode %" PRIu64 " has ille /*
> * Now we can mark entries with BADFSINO's bad.
> */
Comment above needs update.
> - if (!no_modify && ent_ino == BADFSINO) {
> - dep->name[0] = '/';
> + if (!no_modify && dep->name[0] == '/') {
> *dirty = 1;
> junkit = 0;
> }
> +
> /*
> * Special .. entry processing.
> */
--
Arkadiusz Miśkiewicz, arekm / maven.pl
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-01 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 12:54 [PATCH 0/4] repair: fixes for 3.2 Dave Chinner
2014-07-01 12:54 ` [PATCH 1/4] repair: handle directory block corruption in phase 6 Dave Chinner
2014-07-01 12:54 ` [PATCH 2/4] libxfs: buffers aren't stale once written Dave Chinner
2014-07-01 12:54 ` [PATCH 3/4] repair: fix quota inode handling in secondary superblocks Dave Chinner
2014-07-01 12:54 ` [PATCH 4/4] repair: get rid of BADFSINO Dave Chinner
2014-07-01 13:43 ` Arkadiusz Miśkiewicz [this message]
2014-07-01 13:40 ` [PATCH 0/4] repair: fixes for 3.2 Arkadiusz Miśkiewicz
2014-07-01 20:03 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201407011543.49828.arekm@maven.pl \
--to=arekm@maven.pl \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox