public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Arkadiusz Miśkiewicz" <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/4] repair: fixes for 3.2
Date: Wed, 2 Jul 2014 06:03:31 +1000	[thread overview]
Message-ID: <20140701200331.GC9508@dastard> (raw)
In-Reply-To: <201407011540.57511.arekm@maven.pl>

On Tue, Jul 01, 2014 at 03:40:56PM +0200, Arkadiusz Miśkiewicz wrote:
> On Tuesday 01 of July 2014, Dave Chinner wrote:
> > Hi Arkadiusz,
> > 
> > These are the fixes I have so far from working through the metadumps
> > you supplied me with. The unobfuscated metadump repairs cleanly with
> > these patches, but the obfuscated one still has a directory rebuild
> > issue that I haven't got to the bottom of yet. That results in
> > an error in phase 6 like:
> > 
> > Metadata corruption detected at block 0x2af84770/0x1000
> > name create failed in ino 2306912354 (117), filesystem may be out of space
> > 
> > It appears that a read verifier is on a recently created
> > directory leaf block and that is failing. I'm not yet sure why the
> > leaf block is corrupt, nor why the verifier is even being run on it
> > seeing as it was only allocated and initialised during the directory
> > rebuild. That directory rebuil dfailure is the reason for all the
> > disconected inode that end up in lost+found, and I think it's the
> > only remaining issue that I need to solve.
> > 
> > Can you test the patches on you machine and see if you get the same
> > results?
> 
> Testing on non obfuscated image here.
> 
> Most of issues got fixed, first xfs_repair run:
> http://ixion.pld-linux.org/~arekm/p2/x1/repair-3.2-dchinner1-4patches-run1.txt 
> 
> second xfs_repair run (reports no problems):
> http://ixion.pld-linux.org/~arekm/p2/x1/repair-3.2-dchinner1-4patches-run2.txt
> 
> When trying to mount
> "XFS (loop0): Failed to initialize disk quotas."
> so this issue left.

Yeah, I haven't got that far yet....

> Question:
> 
> Phase 2 - using internal log
>         - zero log...
> zero_log: head block 2 tail block 2
>         - scan filesystem freespace and inode maps...
> Metadata CRC error detected at block 0x0/0x200
> 
> Is "Metadata CRC error detected at block" expected here? I mean v4 fs, so no 
> CRC.

Given that it was followed by:

zeroing unused portion of primary superblock (AG #0)

Then there was garbage in the superblock that made the verifier
think that maybe it was missing a feature bit. It didn't come up the
second time, so everything is fine....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2014-07-01 20:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 12:54 [PATCH 0/4] repair: fixes for 3.2 Dave Chinner
2014-07-01 12:54 ` [PATCH 1/4] repair: handle directory block corruption in phase 6 Dave Chinner
2014-07-01 12:54 ` [PATCH 2/4] libxfs: buffers aren't stale once written Dave Chinner
2014-07-01 12:54 ` [PATCH 3/4] repair: fix quota inode handling in secondary superblocks Dave Chinner
2014-07-01 12:54 ` [PATCH 4/4] repair: get rid of BADFSINO Dave Chinner
2014-07-01 13:43   ` Arkadiusz Miśkiewicz
2014-07-01 13:40 ` [PATCH 0/4] repair: fixes for 3.2 Arkadiusz Miśkiewicz
2014-07-01 20:03   ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140701200331.GC9508@dastard \
    --to=david@fromorbit.com \
    --cc=arekm@maven.pl \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox