Re: [PATCH 4/5] xfs: free inodes on log recovery error

Christoph Hellwig
2014-07-09T09:02:30Z

On Wed, Jul 02, 2014 at 09:32:10AM -0500, Mark Tinguely wrote:
> Recovery may free inodes that end up on the inode
> reclaim RCU. If recovery fails, we leak these inodes.
> The filesystem should be in forced shutdown at this
> point, so a call to xfs_reclaim_inode is a fast path
> to freeing the inodes and RCU entries.

I haven't really started reviewing the series, but your terminology
here seems wrong. RCU is just a way to synchronize updates - do you
mean inodes are marked as reclaimable in the radix tree?