From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id BFBA87F3F for ; Fri, 4 Jul 2014 09:08:56 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id C3A89304032 for ; Fri, 4 Jul 2014 07:08:53 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id nRO2vxssoYy6NhMB (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 04 Jul 2014 07:08:52 -0700 (PDT) Date: Fri, 4 Jul 2014 07:08:51 -0700 From: Christoph Hellwig Subject: Re: [PATCH 2/6] xfs_db: write command broken on 64 bit values Message-ID: <20140704140851.GA29520@infradead.org> References: <1404453435-1915-1-git-send-email-david@fromorbit.com> <1404453435-1915-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1404453435-1915-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Jul 04, 2014 at 03:57:11PM +1000, Dave Chinner wrote: > From: Dave Chinner > > convert_args() has problesm with 64 bit fields because it tries to > shift them by 64 bits. The result of doing so is undefined by the C > standard, and so results in the unexpected behaviour of the result > being being the original value unchanged rather than 0. Hence you > can't write 64 bit fields because the code thinks that all values > other than 0 are out of range. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs