From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] libxfs: clear the buffer error while the buffer is locked
Date: Wed, 9 Jul 2014 01:59:13 -0700 [thread overview]
Message-ID: <20140709085913.GA24910@infradead.org> (raw)
In-Reply-To: <1404862900-3369-2-git-send-email-david@fromorbit.com>
On Wed, Jul 09, 2014 at 09:41:39AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When releasing a buffer, the error shoul dbe cleared while the lock
> is still held on the buffer to avoid racing with a new user of the
> buffer.
>
> This was pointed out in review of commit 6af7c1e ("libxfs: reused
> invalidated buffers leak state and data") but the version committed
> didn't have the fix. Thanks to Christoph Hellwig for checking and
> pointing out the oversight.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-09 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 23:41 [PATCH 0/2] repair: more fixes for 3.2.1 Dave Chinner
2014-07-08 23:41 ` [PATCH 1/2] libxfs: clear the buffer error while the buffer is locked Dave Chinner
2014-07-09 8:59 ` Christoph Hellwig [this message]
2014-07-08 23:41 ` [PATCH 2/2] repair: handle uncorrected corruptions in phase 2 Dave Chinner
2014-07-09 9:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709085913.GA24910@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox