From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id CD33C7F67 for ; Sat, 12 Jul 2014 20:26:30 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 626CCAC002 for ; Sat, 12 Jul 2014 18:26:30 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id d3JBDrj8TrWu9AJu for ; Sat, 12 Jul 2014 18:26:28 -0700 (PDT) Date: Sun, 13 Jul 2014 11:26:24 +1000 From: Dave Chinner Subject: Re: consequences of XFS_IOC_FSSETXATTR on non-empty file? Message-ID: <20140713012624.GS4453@dastard> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Samuel Just Cc: Ilya Dryomov , "ceph-devel@vger.kernel.org" , Sage Weil , xfs@oss.sgi.com On Sat, Jul 12, 2014 at 06:16:54PM -0700, Samuel Just wrote: > Hi, > > We are seeing reports of ceph-osd stores on xfs of files with some > garbage data (possibly misplaced from data elsewhere in the > filesystem). There was a bug for a while where the ceph-osd process > would set a value for fsx_extsize on a non-empty (possibly sparse) > file using XFS_IOC_FSSETXATTR. Could that plausibly result in a file > with garbage data? No, setting an extent size on a non-empty file will simply fail with EINVAL. Do you have any method of reproducing the bad data in files? Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs