From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 429857F4E for ; Mon, 14 Jul 2014 15:23:36 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id E19D7AC004 for ; Mon, 14 Jul 2014 13:23:35 -0700 (PDT) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id XkRKMO6ZG9U0Clk1 for ; Mon, 14 Jul 2014 13:23:33 -0700 (PDT) Date: Tue, 15 Jul 2014 06:23:31 +1000 From: Dave Chinner Subject: Re: consequences of XFS_IOC_FSSETXATTR on non-empty file? Message-ID: <20140714202330.GU4453@dastard> References: <20140713012624.GS4453@dastard> <20140713225532.GD22339@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ilya Dryomov Cc: "ceph-devel@vger.kernel.org" , Sage Weil , Samuel Just , xfs@oss.sgi.com On Mon, Jul 14, 2014 at 11:24:05AM +0400, Ilya Dryomov wrote: > On Mon, Jul 14, 2014 at 2:55 AM, Dave Chinner wrote: > > On Sun, Jul 13, 2014 at 09:01:13PM +0400, Ilya Dryomov wrote: > >> On Sun, Jul 13, 2014 at 5:48 AM, Samuel Just wrote: > >> I think if you call fsync() or even > >> fdatasync() before close(fd), it will fail as expected. > > > > Only if you are trying to change the extent size immediately after > > the first write you do to an empty file. Which is, as per the above, > > not the recommended or intended use of the ioctl. > > That's understood, but that is exactly what Sam's test program happens > to try to do, so I had to point the "file w/o real extents" thing out. Oh, I missed that there was a test program attached. That's what happens when people top post a reply then attach text at the bottom.... Moral of the story: don't top post ;) Cheersm Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs