From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] logprint: Fix printing of AGF buffers
Date: Tue, 15 Jul 2014 03:19:31 -0700 [thread overview]
Message-ID: <20140715101931.GC30363@infradead.org> (raw)
In-Reply-To: <1405349100-19734-1-git-send-email-jack@suse.cz>
On Mon, Jul 14, 2014 at 04:45:00PM +0200, Jan Kara wrote:
> Currently xfs_logprint doesn't show detailed data about AGF buffers and
> instead always shows "Out of space". This is because xfs_agf_t has
> additional fields and padding which we never read from disk and thus
> buffer length is always smaller than the size of xfs_agf_t.
>
> Fix the problem by only making sure we have enough data in the buffer
> to contain all the information we want to print.
The fix looks correct to me, but te explanation should be more verbose:
the reason why we don't read agf_uuid and above is because you're
probably dumping a v4 filesystems which doesn't even have those fields.
Its seems like various other fields have the same issue in logprint,
and I also suspect we want some defines for the v4 size instead of using
the offsetoff tricks.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-15 10:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 14:45 [PATCH] logprint: Fix printing of AGF buffers Jan Kara
2014-07-15 10:19 ` Christoph Hellwig [this message]
2014-07-15 14:09 ` Jan Kara
2014-07-15 15:39 ` Christoph Hellwig
2014-07-16 0:38 ` Dave Chinner
2014-07-16 8:11 ` Christoph Hellwig
2014-07-16 20:33 ` Jan Kara
2014-07-16 23:17 ` Dave Chinner
2014-07-17 8:39 ` Jan Kara
2014-07-18 0:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715101931.GC30363@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox