From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] logprint: Fix printing of AGF buffers
Date: Tue, 15 Jul 2014 08:39:22 -0700 [thread overview]
Message-ID: <20140715153922.GB5369@infradead.org> (raw)
In-Reply-To: <20140715140938.GA1733@quack.suse.cz>
On Tue, Jul 15, 2014 at 04:09:38PM +0200, Jan Kara wrote:
> I had a look before I submitted this patch and I didn't find anything.
> Now that I'm looking again, AGI buffers probably need a similar treatment.
> Superblock buffers are already checked against fixed number so those don't
> have a problem. Dquot buffers should be fine as well because those don't
> have a checksum and other unlogged stuff. And I didn't find any other
> structures in the log that would have the problem (please point me if I
> missed something).
>
> Regarding how to fix this cleanly - offsetof() seems like a reasonably
> clean way to me. If you prefer to define number of bytes each buffer type
> has to have in the log, I can do that as well. Or I could define
> alternative structures only containing fields we need in the log so that we
> can print info but this all seems like an additional complexity with
> disputable gain...
I've taken a bit of a closer log (OMG, what a mess logprint is..), and
it seems at least in this are the AGF and AGI are affected of the struct
growth in v4.
It seems like in this specific case using your offsetoff trick is
fine, it just needs a good comment explaining it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-15 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 14:45 [PATCH] logprint: Fix printing of AGF buffers Jan Kara
2014-07-15 10:19 ` Christoph Hellwig
2014-07-15 14:09 ` Jan Kara
2014-07-15 15:39 ` Christoph Hellwig [this message]
2014-07-16 0:38 ` Dave Chinner
2014-07-16 8:11 ` Christoph Hellwig
2014-07-16 20:33 ` Jan Kara
2014-07-16 23:17 ` Dave Chinner
2014-07-17 8:39 ` Jan Kara
2014-07-18 0:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715153922.GB5369@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox