From: Christoph Hellwig <hch@infradead.org>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota
Date: Wed, 16 Jul 2014 00:12:50 -0700 [thread overview]
Message-ID: <20140716071250.GA1461@infradead.org> (raw)
In-Reply-To: <53C62595.6010702@oracle.com>
On Wed, Jul 16, 2014 at 03:11:17PM +0800, Jeff Liu wrote:
> > This code was introduced by commit
> > 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc which attempts to fix the
> > broken quotarm code. Seems like we need a testcase for this
> > functionality or just remove it. Physically removing the quota file
> > never seems that useful to me to start with..
>
> Is there an approach to verify that a particular quota file inode has
> been successfully removed? It seems we have to do this in a test case
> but am not yet figure out a way, or any thoughts for the test case?
umount the filesystem and check that the field in the superblock
pointing to that kind of quota inode is zeroed out would be my
suggestion.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-16 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 9:35 [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota Jeff Liu
2014-07-15 10:25 ` Christoph Hellwig
2014-07-16 7:11 ` Jeff Liu
2014-07-16 7:12 ` Christoph Hellwig [this message]
2014-07-16 8:32 ` Jeff Liu
2014-07-16 17:10 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716071250.GA1461@infradead.org \
--to=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox