From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
xfs@oss.sgi.com
Subject: Re: [PATCH] logprint: Fix printing of AGF buffers
Date: Wed, 16 Jul 2014 01:11:05 -0700 [thread overview]
Message-ID: <20140716081105.GB29924@infradead.org> (raw)
In-Reply-To: <20140716003851.GO22339@dastard>
On Wed, Jul 16, 2014 at 10:38:51AM +1000, Dave Chinner wrote:
> I added this:
>
> /*
> * The addition of spare space and the non-logged CRC format
> * fields to the AGF mean that the size that is logged is almost
> * always going to be smaller than the structure itself. Hence
> * we need to make sure that the buffer contains all the data we
> * want to print rather than just check against the structure
> * size.
> */
>
> Cheers,
I'd prefer to mention v4 filesystems as well:
/*
* v4 filesystems only contain the fields before the uuid, and
* even v5 filesystems don't usually log any field beneath it.
*/
note that the AGI case also needs the same treatment.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-16 8:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 14:45 [PATCH] logprint: Fix printing of AGF buffers Jan Kara
2014-07-15 10:19 ` Christoph Hellwig
2014-07-15 14:09 ` Jan Kara
2014-07-15 15:39 ` Christoph Hellwig
2014-07-16 0:38 ` Dave Chinner
2014-07-16 8:11 ` Christoph Hellwig [this message]
2014-07-16 20:33 ` Jan Kara
2014-07-16 23:17 ` Dave Chinner
2014-07-17 8:39 ` Jan Kara
2014-07-18 0:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716081105.GB29924@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox