From: Brian Foster <bfoster@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] repair: Set ftype for entries in lost+found
Date: Tue, 22 Jul 2014 07:53:11 -0400 [thread overview]
Message-ID: <20140722115311.GA64423@bfoster.bfoster> (raw)
In-Reply-To: <1405970485-19888-1-git-send-email-jack@suse.cz>
On Mon, Jul 21, 2014 at 09:21:25PM +0200, Jan Kara wrote:
> So far all entries in lost+found had file type XFS_DIR3_FT_UNKNOWN which
> is somewhat annoying as the next xfs_repair pass will find these and
> report as an error. Set proper file type when creating these entries.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> repair/phase6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/repair/phase6.c b/repair/phase6.c
> index f13069f4cd71..0ec4f07ca1c2 100644
> --- a/repair/phase6.c
> +++ b/repair/phase6.c
> @@ -1097,8 +1097,6 @@ mv_orphanage(
> xname.name = fname;
> xname.len = snprintf((char *)fname, sizeof(fname), "%llu",
> (unsigned long long)ino);
> - /* XXX use xfs_mode_to_ftype[] when userspace gains it */
> - xname.type = XFS_DIR3_FT_UNKNOWN;
>
> err = libxfs_iget(mp, NULL, orphanage_ino, 0, &orphanage_ip, 0);
> if (err)
> @@ -1117,6 +1115,8 @@ mv_orphanage(
> if ((err = libxfs_iget(mp, NULL, ino, 0, &ino_p, 0)))
> do_error(_("%d - couldn't iget disconnected inode\n"), err);
>
> + xname.type = xfs_mode_to_ftype[(ino_p->i_d.di_mode & S_IFMT)>>S_SHIFT];
> +
> if (isa_dir) {
> irec = find_inode_rec(mp, XFS_INO_TO_AGNO(mp, orphanage_ino),
> XFS_INO_TO_AGINO(mp, orphanage_ino));
> --
> 1.8.1.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-07-22 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 19:21 [PATCH] repair: Set ftype for entries in lost+found Jan Kara
2014-07-22 11:53 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722115311.GA64423@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox