From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: Is jdm_delete_filehandle part of a public API?
Date: Wed, 30 Jul 2014 09:46:55 +1000 [thread overview]
Message-ID: <20140729234655.GK26465@dastard> (raw)
In-Reply-To: <53D7DA7F.2040706@redhat.com>
On Tue, Jul 29, 2014 at 12:31:43PM -0500, Eric Sandeen wrote:
> I was cleaning up xfsprogs to plug some leaks, and wanted to use
> jdm_delete_filehandle(). I noticed that it has an "hlen" argument which
> is unused.
>
> Can we remove that, or is this part of a public API? It's not in any
> manpage (or even called anywhere in xfsprogs/xfstests/xfsdump/dmapi)
> but it is in a public header...
Which means it is part of the published API, regardless of whether
it is documented in the man page or not.
As it is, we've never really cared about ABI stability for these
libraries - I don't think we've ever guaranteed stability in any
way. If you want to change it, though, I suspect we'll need to bump
the library version....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-29 23:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 17:31 Is jdm_delete_filehandle part of a public API? Eric Sandeen
2014-07-29 18:18 ` Mark Tinguely
2014-07-29 20:04 ` Mark Tinguely
2014-07-29 20:18 ` Eric Sandeen
2014-07-29 20:54 ` Mark Tinguely
2014-07-29 23:46 ` Dave Chinner [this message]
2014-08-01 13:53 ` Christoph Hellwig
2014-08-04 2:20 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729234655.GK26465@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox