From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfs: catch buffers written without verifiers attached
Date: Wed, 30 Jul 2014 12:29:26 +1000 [thread overview]
Message-ID: <20140730022926.GL26465@dastard> (raw)
In-Reply-To: <1406684929-11133-2-git-send-email-david@fromorbit.com>
On Wed, Jul 30, 2014 at 11:48:46AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> We recently had a bug where buffers were slipping through log
> recovery without any verifier attached to them. This was resulting
> in on-disk CRC mismatches for valid data. Add some warning code to
> catch this occurrence so that we catch such bugs durin development
> rather than not being aware they exist.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Oops, this is an old version - didn't refresh the patch properly,
see V2...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-30 2:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 1:48 [PATCH 0/4] xfs: missing verifer fixes Dave Chinner
2014-07-30 1:48 ` [PATCH 1/4] xfs: catch buffers written without verifiers attached Dave Chinner
2014-07-30 2:29 ` Dave Chinner [this message]
2014-07-30 2:30 ` [PATCH 1/4 V2] " Dave Chinner
2014-07-30 16:29 ` Brian Foster
2014-07-30 21:39 ` Dave Chinner
2014-07-30 1:48 ` [PATCH 2/4] xfs: ensure verifiers are attached to recovered buffers Dave Chinner
2014-07-30 16:30 ` Brian Foster
2014-07-30 1:48 ` [PATCH 3/4] xfs: quotacheck leaves dquot buffers without verifiers Dave Chinner
2014-07-30 16:30 ` Brian Foster
2014-07-30 1:48 ` [PATCH 4/4] xfs: dquot recovery needs verifiers Dave Chinner
2014-07-30 12:30 ` Fanael Linithien
2014-07-30 21:43 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2014-07-31 1:01 [PATCH 0/4 V2] xfs: missing verifier fixes Dave Chinner
2014-07-31 1:01 ` [PATCH 1/4] xfs: catch buffers written without verifiers attached Dave Chinner
2014-07-31 12:27 ` Brian Foster
2014-08-01 14:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730022926.GL26465@dastard \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox