From: Dave Chinner <david@fromorbit.com>
To: Fanael Linithien <fanael4@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfs: dquot recovery needs verifiers
Date: Thu, 31 Jul 2014 07:43:34 +1000 [thread overview]
Message-ID: <20140730214334.GN20518@dastard> (raw)
In-Reply-To: <CA+o=1OWqWXXLGLB9-TgkmBUDfFs0GpmQS=4to3tO6-R0FvgLuA@mail.gmail.com>
On Wed, Jul 30, 2014 at 02:30:11PM +0200, Fanael Linithien wrote:
> 2014-07-30 3:48 GMT+02:00 Dave Chinner <david@fromorbit.com>:
> > + if (!mp->m_qflags == 0)
> > + return false;
>
> Is it a typo, or is it intentionally obfuscated mp->m_qflags != 0?
Ugh. Two patches in the series that weren't properly uptodate. I'll
resend the series....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-30 21:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 1:48 [PATCH 0/4] xfs: missing verifer fixes Dave Chinner
2014-07-30 1:48 ` [PATCH 1/4] xfs: catch buffers written without verifiers attached Dave Chinner
2014-07-30 2:29 ` Dave Chinner
2014-07-30 2:30 ` [PATCH 1/4 V2] " Dave Chinner
2014-07-30 16:29 ` Brian Foster
2014-07-30 21:39 ` Dave Chinner
2014-07-30 1:48 ` [PATCH 2/4] xfs: ensure verifiers are attached to recovered buffers Dave Chinner
2014-07-30 16:30 ` Brian Foster
2014-07-30 1:48 ` [PATCH 3/4] xfs: quotacheck leaves dquot buffers without verifiers Dave Chinner
2014-07-30 16:30 ` Brian Foster
2014-07-30 1:48 ` [PATCH 4/4] xfs: dquot recovery needs verifiers Dave Chinner
2014-07-30 12:30 ` Fanael Linithien
2014-07-30 21:43 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-31 1:01 [PATCH 0/4 V2] xfs: missing verifier fixes Dave Chinner
2014-07-31 1:01 ` [PATCH 4/4] xfs: dquot recovery needs verifiers Dave Chinner
2014-07-31 12:27 ` Brian Foster
2014-08-01 14:30 ` Christoph Hellwig
2014-08-02 3:20 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730214334.GN20518@dastard \
--to=david@fromorbit.com \
--cc=fanael4@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox