Re: [PATCH 4/9] xfs: kill xfs_bdstrat_cb

Christoph Hellwig
2014-08-29T00:24:38Z

On Fri, Aug 15, 2014 at 04:39:02PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Only has two callers, and is just a shutdown check and error handler
> around xfs_buf_iorequest. However, the error handling is a mess of
> read and write semantics, and both internal callers only call it for
> writes. Hence kill the wrapper, and follow up with a patch to
> sanitise the error handling.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>