Re: [PATCH 5/9] xfs: xfs_bioerror can die.

Dave Chinner
2014-08-29T01:06:19Z

On Thu, Aug 28, 2014 at 05:28:25PM -0700, Christoph Hellwig wrote:
> On Fri, Aug 15, 2014 at 04:39:03PM +1000, Dave Chinner wrote:
> > Internal buffer write error handling is a mess due to the unnatural
> > split between xfs_bioerror and xfs_bioerror_relse(). The buffer
> > reference counting is also wrong for the xfs_bioerror path for
> > xfs_bwrite - it uses sync IO and so xfs_buf_ioend will release a
> > hold count that was never taken.
>
> Which seems to be cause by patch 1 in the series, and thus the
> additional hold for the error case should be introduced there.

will fix.

--
Dave Chinner
david@fromorbit.com