Re: [PATCH 9/9] xfs: check xfs_buf_read_uncached returns correctly

Christoph Hellwig
2014-08-29T00:37:57Z

On Sat, Aug 16, 2014 at 09:58:43AM +1000, Dave Chinner wrote:
> > I'd rather get rid of these annoying calling conventions. Make it
> > return and errno, and the bp in a pointer argument, with the bp
> > never non-NULL in case of error.
>
> Ok. I considered that, then just did the simple thing.

There's only about a dozen callers of all xfs_buf_read* variants, so
I think switching them over to return an errno shouldn't be much of a
problem.