From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: clm@fb.com, xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] xfs: use ranged writeback and invalidation for direct IO
Date: Thu, 21 Aug 2014 09:09:18 -0400 [thread overview]
Message-ID: <20140821130918.GE64112@bfoster.bfoster> (raw)
In-Reply-To: <1408597754-13526-5-git-send-email-david@fromorbit.com>
On Thu, Aug 21, 2014 at 03:09:12PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Now we are not doing silly things with dirtying buffers beyond EOF
> and using invalidation correctly, we can finally reduce the ranges of
> writeback and invalidation used by direct IO to match that of the IO
> being issued.
>
> Bring the writeback and invalidation ranges back to match the
> generic direct IO code - this will greatly reduce the perturbation
> of cached data when direct IO and buffered IO are mixed, but still
> provide the same buffered vs direct IO coherency behaviour we
> currently have.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_file.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 19917fa..de5368c 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -291,7 +291,7 @@ xfs_file_read_iter(
> if (inode->i_mapping->nrpages) {
> ret = filemap_write_and_wait_range(
> VFS_I(ip)->i_mapping,
> - pos, -1);
> + pos, pos + size - 1);
> if (ret) {
> xfs_rw_iunlock(ip, XFS_IOLOCK_EXCL);
> return ret;
> @@ -303,7 +303,8 @@ xfs_file_read_iter(
> * happen on XFS. Warn if it does fail.
> */
> ret = invalidate_inode_pages2_range(VFS_I(ip)->i_mapping,
> - pos >> PAGE_CACHE_SHIFT, -1);
> + pos >> PAGE_CACHE_SHIFT,
> + (pos + size - 1) >> PAGE_CACHE_SHIFT);
> WARN_ON_ONCE(ret);
> ret = 0;
> }
> @@ -641,7 +642,7 @@ xfs_file_dio_aio_write(
>
> if (mapping->nrpages) {
> ret = filemap_write_and_wait_range(VFS_I(ip)->i_mapping,
> - pos, -1);
> + pos, pos + count - 1);
> if (ret)
> goto out;
> /*
> @@ -650,7 +651,8 @@ xfs_file_dio_aio_write(
> * happen on XFS. Warn if it does fail.
> */
> ret = invalidate_inode_pages2_range(VFS_I(ip)->i_mapping,
> - pos >> PAGE_CACHE_SHIFT, -1);
> + pos >> PAGE_CACHE_SHIFT,
> + (pos + count - 1) >> PAGE_CACHE_SHIFT);
> WARN_ON_ONCE(ret);
> ret = 0;
> }
> --
> 2.0.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-08-21 13:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 5:09 [PATCH 0/6] xfs: direct IO invalidation and related fixes Dave Chinner
2014-08-21 5:09 ` [PATCH 1/6] xfs: mmap write/read leaves bad state on pages Dave Chinner
2014-08-21 12:48 ` Brian Foster
2014-08-21 22:38 ` Dave Chinner
2014-08-21 13:08 ` Christoph Hellwig
2014-08-21 13:54 ` Anton Altaparmakov
2014-08-21 15:21 ` Chris Mason
2014-08-21 19:56 ` Jan Kara
2014-08-21 22:33 ` Dave Chinner
2014-08-26 16:06 ` Jan Kara
2014-08-26 21:38 ` Dave Chinner
2014-08-21 5:09 ` [PATCH 2/6] xfs: don't zero partial page cache pages during O_DIRECT writes Dave Chinner
2014-08-21 13:08 ` Brian Foster
2014-08-21 5:09 ` [PATCH 3/6] " Dave Chinner
2014-08-21 13:09 ` Brian Foster
2014-08-21 5:09 ` [PATCH 4/6] xfs: use ranged writeback and invalidation for direct IO Dave Chinner
2014-08-21 13:09 ` Brian Foster [this message]
2014-08-21 5:09 ` [PATCH 5/6] xfs: don't log inode unless extent shift makes extent modifications Dave Chinner
2014-08-21 5:09 ` [PATCH 6/6] xfs: xfs_file_collapse_range is delalloc challenged Dave Chinner
2014-08-21 13:09 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821130918.GE64112@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox