From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 4EC2D7F5A for ; Thu, 28 Aug 2014 19:24:38 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 2C92E304039 for ; Thu, 28 Aug 2014 17:24:38 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id 5qAxGklIBljrE8BH (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 28 Aug 2014 17:24:37 -0700 (PDT) Date: Thu, 28 Aug 2014 17:24:36 -0700 From: Christoph Hellwig Subject: Re: [PATCH 4/9] xfs: kill xfs_bdstrat_cb Message-ID: <20140829002436.GD17502@infradead.org> References: <1408084747-4540-1-git-send-email-david@fromorbit.com> <1408084747-4540-5-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1408084747-4540-5-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Aug 15, 2014 at 04:39:02PM +1000, Dave Chinner wrote: > From: Dave Chinner > > Only has two callers, and is just a shutdown check and error handler > around xfs_buf_iorequest. However, the error handling is a mess of > read and write semantics, and both internal callers only call it for > writes. Hence kill the wrapper, and follow up with a patch to > sanitise the error handling. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs