Re: [PATCH 3/7] xfs: don't zero partial page cache pages during O_DIRECT writes

Christoph Hellwig
2014-08-29T00:39:53Z

On Thu, Aug 28, 2014 at 09:49:07PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Similar to direct IO reads, direct IO writes are using
> truncate_pagecache_range to invalidate the page cache. This is
> incorrect due to the sub-block zeroing in the page cache that
> truncate_pagecache_range() triggers.
>
> This patch fixes things by using invalidate_inode_pages2_range
> instead. It preserves the page cache invalidation, but won't zero
> any pages.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>