Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype

Eric Sandeen
2014-09-08T01:02:26Z

On 9/7/14 7:10 PM, Dave Chinner wrote:
> On Sun, Sep 07, 2014 at 11:41:04AM -0500, Eric Sandeen wrote:

...

>> diff --git a/include/xfs_da_format.h b/include/xfs_da_format.h
>> index 89a1a21..11f1420 100644
>> --- a/include/xfs_da_format.h
>> +++ b/include/xfs_da_format.h
>> @@ -561,7 +561,6 @@ xfs_dir3_dirent_get_ftype(
>> if (xfs_sb_version_hasftype(&mp->m_sb)) {
>> __uint8_t type = dep->name[dep->namelen];
>>
>> - ASSERT(type < XFS_DIR3_FT_MAX);
>> if (type < XFS_DIR3_FT_MAX)
>> return type;
>
> Needs to be fixed kernel-side first.

xfs_dir3_dirent_get_ftype doesn't exist in kernelspace :)

bleah, why do they have different names... Ok, will send.

-Eric

> Cheers,
>
> Dave.