Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype

Dave Chinner
2014-09-08T03:16:52Z

On Sun, Sep 07, 2014 at 08:02:20PM -0500, Eric Sandeen wrote:
> On 9/7/14 7:10 PM, Dave Chinner wrote:
> >On Sun, Sep 07, 2014 at 11:41:04AM -0500, Eric Sandeen wrote:
>
> ...
>
> >>diff --git a/include/xfs_da_format.h b/include/xfs_da_format.h
> >>index 89a1a21..11f1420 100644
> >>--- a/include/xfs_da_format.h
> >>+++ b/include/xfs_da_format.h
> >>@@ -561,7 +561,6 @@ xfs_dir3_dirent_get_ftype(
> >> if (xfs_sb_version_hasftype(&mp->m_sb)) {
> >> __uint8_t type = dep->name[dep->namelen];
> >>
> >>- ASSERT(type < XFS_DIR3_FT_MAX);
> >> if (type < XFS_DIR3_FT_MAX)
> >> return type;
> >
> >Needs to be fixed kernel-side first.
>
> xfs_dir3_dirent_get_ftype doesn't exist in kernelspace :)
>
> bleah, why do they have different names... Ok, will send.

Because kernel has changed, and we need to do yet another large
kernel/user libxfs sync.

I haven't found time to do that yet. Unless you want to volunteer
for it....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com