Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int

Christoph Hellwig
2014-09-09T22:29:00Z

On Sun, Sep 07, 2014 at 11:41:01AM -0500, Eric Sandeen wrote:
> process_dinode_int() reports bad flags if
> dino->di_flags & ~XFS_DIFLAG_ANY - i.e. if
> any flags are set outside the known set. But
> then instead of clearing them, it does
> flags &= ~XFS_DIFLAG_ANY which keeps *only*
> the bad flags. This leads to persistent,
> unrepairable errors of the form:

You know you can use up to 75 characters per line for your commit messages,
don't you? :)

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>