From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 0/2] xfs log recovery delay instrumentation
Date: Tue, 9 Sep 2014 11:56:01 +1000 [thread overview]
Message-ID: <20140909015601.GV30012@dastard> (raw)
In-Reply-To: <1409666895-49799-1-git-send-email-bfoster@redhat.com>
On Tue, Sep 02, 2014 at 10:08:13AM -0400, Brian Foster wrote:
> Here's v2 of the log recovery delay instrumentation set. v1 is available
> here:
>
> http://oss.sgi.com/archives/xfs/2014-08/msg00276.html
>
> After a brief conversation with Dave, we thought it best to tie in this
> functionality with DEBUG mode to express/ensure that these attributes
> are for debugging/hacking purposes only. Everything else should be
> equivalent to v1.
>
> Brian
>
> v2:
> - Enable /sys/fs/xfs/debug for DEBUG mode kernels only.
> v1: http://oss.sgi.com/archives/xfs/2014-08/msg00276.html
>
> Brian Foster (2):
> xfs: add debug sysfs attribute set
> xfs: export log_recovery_delay to delay mount time log recovery
These look good. I'm sure that as we add more attributes there will
be opportunity for factoring/streamlining this code more, but right
now I don't think that is necessary.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-09-09 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 14:08 [PATCH v2 0/2] xfs log recovery delay instrumentation Brian Foster
2014-09-02 14:08 ` [PATCH v2 1/2] xfs: add debug sysfs attribute set Brian Foster
2014-09-02 14:08 ` [PATCH v2 2/2] xfs: export log_recovery_delay to delay mount time log recovery Brian Foster
2014-09-09 1:56 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909015601.GV30012@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox