public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V3] xfs_io: add mremap command
Date: Sat, 13 Sep 2014 12:45:59 -0700	[thread overview]
Message-ID: <20140913194559.GA28479@infradead.org> (raw)
In-Reply-To: <54132553.9090202@sandeen.net>

On Fri, Sep 12, 2014 at 11:54:43AM -0500, Eric Sandeen wrote:
> This adds a simple mremap command to xfs_io.
> 
> It does not take a start address; it uses the existing
> start address, so the sized passed will be the new total
> size of the mapping.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks good to me, but I'd feel much more comfortable about merging it
if we had an xfstests test case that actually exercises it.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-09-13 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  3:25 [PATCH] xfs_io: add mremap command Eric Sandeen
2014-09-11  3:29 ` [PATCH V2] " Eric Sandeen
2014-09-12 16:22   ` Eric Sandeen
2014-09-12 16:54 ` [PATCH V3] " Eric Sandeen
2014-09-13 19:45   ` Christoph Hellwig [this message]
2014-09-13 20:12     ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140913194559.GA28479@infradead.org \
    --to=hch@infradead.org \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox