From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfsrestore: use utimensat() to provide atime/mtime with ns resolution
Date: Sat, 13 Sep 2014 12:47:13 -0700 [thread overview]
Message-ID: <20140913194713.GB28479@infradead.org> (raw)
In-Reply-To: <1409866939-1480-1-git-send-email-bfoster@redhat.com>
On Thu, Sep 04, 2014 at 05:42:19PM -0400, Brian Foster wrote:
> xfsdump encodes and stores the full atime and mtime for each file with
> nanosecond resolution. xfsrestore uses utime() to set the times of each
> file that is restored. The latter supports resolution of 1 second, thus
> sub-second timestamp data is lost on restore.
>
> Add the associated configure checks for and use utimensat() when
> available to restore timestamps with nanosecond resolution. Create a new
> helper to facilitate conditional support for utimensat().
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-09-13 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 21:42 [PATCH v2] xfsrestore: use utimensat() to provide atime/mtime with ns resolution Brian Foster
2014-09-13 19:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140913194713.GB28479@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox