From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] libxfs: use structure initializers for cache_operations
Date: Mon, 22 Sep 2014 09:21:07 -0400 [thread overview]
Message-ID: <20140922132107.GB29156@bfoster.bfoster> (raw)
In-Reply-To: <541C95B1.9020807@sandeen.net>
On Fri, Sep 19, 2014 at 03:44:33PM -0500, Eric Sandeen wrote:
> This makes it a lot easier for cscope etc.
>
> Surely all modern compilers can cope?
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Seems reasonable to me.
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 9ee89d3..80de6fa 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -1088,12 +1088,12 @@ libxfs_bcache_overflowed(void)
> }
>
> struct cache_operations libxfs_bcache_operations = {
> - /* .hash */ libxfs_bhash,
> - /* .alloc */ libxfs_balloc,
> - /* .flush */ libxfs_bflush,
> - /* .relse */ libxfs_brelse,
> - /* .compare */ libxfs_bcompare,
> - /* .bulkrelse */libxfs_bulkrelse
> + .hash = libxfs_bhash,
> + .alloc = libxfs_balloc,
> + .flush = libxfs_bflush,
> + .relse = libxfs_brelse,
> + .compare = libxfs_bcompare,
> + .bulkrelse = libxfs_bulkrelse
> };
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-09-22 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 20:44 [PATCH] libxfs: use structure initializers for cache_operations Eric Sandeen
2014-09-22 13:21 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922132107.GB29156@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox