From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: adilger@dilger.ca, Jan Kara <jack@suse.cz>,
linux-api@vger.kernel.org, xfs@oss.sgi.com, dmonakhov@openvz.org,
viro@zeniv.linux.org.uk, Li Xi <pkuelelixi@gmail.com>,
linux-fsdevel@vger.kernel.org, tytso@mit.edu,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/4] Adds ioctl interface support for ext4 project
Date: Wed, 24 Sep 2014 19:01:05 +0200 [thread overview]
Message-ID: <20140924170105.GE27000@quack.suse.cz> (raw)
In-Reply-To: <20140924162634.GA16886@infradead.org>
On Wed 24-09-14 09:26:34, Christoph Hellwig wrote:
> On Wed, Sep 24, 2014 at 06:25:07PM +0200, Jan Kara wrote:
> > On Wed 24-09-14 22:04:30, Li Xi wrote:
> > > This patch adds ioctl interface for setting/getting project of ext4.
> > The patch looks good to me. I was just wondering whether it won't be
> > useful to add an ioctl() which isn't ext4 specific. We could just extend
> > ->setattr() to allow setting of project ID (most filesystems would just
> > return -EOPNOTSUPP but ext4 and xfs could do the right thing) and then call
> > ->setattr from the generic ioctl. That way userspace won't have to care
> > about filesystem type when setting project ID... What do others think?
>
> Absolutely. In general I also wonder why this patch doesn't implement
> the full XFS API. Maybe there is a reason it was considered and
> rejected, but it would be helpful to document why.
Do you mean full get/setfsxattr API? That basically contains project ID,
flags (those that are currently get/set with FS_IOC_GETFLAGS/SETFLAGS), and
extent size hint right? That seems workable and it would also make setting
of PROJINHERIT flag fs agnostic. Only we would have to create some generic
flags namespace and merge into that ext4 flags and have a translation
function for the old ext4 flags. Also I'm afraid we may quickly run out of
32 available flags in xflags so we'd need to extend that. But all this
seems to be doable.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-24 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411567470-31799-1-git-send-email-lixi@ddn.com>
[not found] ` <1411567470-31799-5-git-send-email-lixi@ddn.com>
2014-09-24 16:25 ` [PATCH 4/4] Adds ioctl interface support for ext4 project Jan Kara
2014-09-24 16:26 ` Christoph Hellwig
2014-09-24 17:01 ` Jan Kara [this message]
2014-09-25 7:59 ` Dave Chinner
2014-09-25 11:34 ` lixi
2014-09-26 0:10 ` Dave Chinner
2014-09-26 2:45 ` Li Xi
2014-09-25 13:41 ` Theodore Ts'o
2014-09-25 22:22 ` Dave Chinner
2014-09-25 13:52 ` Jan Kara
2014-09-25 22:42 ` Dave Chinner
2014-09-26 12:01 ` Theodore Ts'o
2014-09-29 15:55 ` Jan Kara
2014-09-25 7:26 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924170105.GE27000@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger@dilger.ca \
--cc=dmonakhov@openvz.org \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pkuelelixi@gmail.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox