From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable()
Date: Fri, 26 Sep 2014 07:03:30 +1000 [thread overview]
Message-ID: <20140925210330.GG4945@dastard> (raw)
In-Reply-To: <20140925161756.GA25798@infradead.org>
On Thu, Sep 25, 2014 at 09:17:56AM -0700, Christoph Hellwig wrote:
> > index d36bdbc..9073895 100644
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -607,7 +607,7 @@ xfs_mount_reset_sbqflags(
> > * If the fs is readonly, let the incore superblock run
> > * with quotas off but don't flush the update out to disk
> > */
> > - if (mp->m_flags & XFS_MOUNT_RDONLY)
> > + if (!xfs_fs_writable(mp, SB_UNFROZEN))
>
> This adds a new caller of xfs_fs_writable, which isn't mentioned in the
> changelog.
I can mention it, but it's so trivial I didn't think it was worth
it.
> > + /*
> > + * We can be called during the fs freeze process, and we need to be
> > + * able to write the superblock in that case.
> > + */
> > + if (!xfs_fs_writable(mp, SB_FREEZE_FS))
> > return 0;
>
> And this already changes the checked freeze level, also not mentioned.
The changelog says "Hence allow the caller to pass in the freeze
level it is allowed to write" which is exactly what this code is
doing.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-25 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 12:20 [PATCH 0/3 v2] xfs: superblock logging rework Dave Chinner
2014-09-25 12:20 ` [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable() Dave Chinner
2014-09-25 16:17 ` Christoph Hellwig
2014-09-25 21:03 ` Dave Chinner [this message]
2014-09-26 9:44 ` Christoph Hellwig
2014-09-29 12:18 ` Brian Foster
2014-09-25 12:20 ` [PATCH 2/3] xfs: remove bitfield based superblock updates Dave Chinner
2014-09-26 9:45 ` Christoph Hellwig
2014-09-26 23:01 ` Dave Chinner
2014-09-26 10:00 ` Christoph Hellwig
2014-09-26 23:02 ` Dave Chinner
2014-09-25 12:20 ` [PATCH 3/3] xfs: consolidate superblock logging functions Dave Chinner
2014-09-29 13:20 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925210330.GG4945@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox