From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: reorganise transaction recovery item code
Date: Fri, 26 Sep 2014 05:05:56 -0700 [thread overview]
Message-ID: <20140926120556.GC10574@infradead.org> (raw)
In-Reply-To: <1411697952-24741-5-git-send-email-david@fromorbit.com>
On Fri, Sep 26, 2014 at 12:19:11PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The code for managing transactions anf the items for recovery is
> spread across 3 different locations in the file. Move them all
> together so that it is easy to read the code without needing to jump
> long distances in the file.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-26 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 2:19 [PATCH 0/5 v2] xfs: clean up xlog_recover_process_data Dave Chinner
2014-09-26 2:19 ` [PATCH 1/5] xfs: refactor xlog_recover_process_data() Dave Chinner
2014-09-26 11:42 ` Christoph Hellwig
2014-09-26 23:22 ` Dave Chinner
2014-09-26 2:19 ` [PATCH 2/5] xfs: recovery of XLOG_UNMOUNT_TRANS leaks memory Dave Chinner
2014-09-26 12:01 ` Christoph Hellwig
2014-09-26 23:27 ` Dave Chinner
2014-09-26 2:19 ` [PATCH 3/5] xfs: fix double free in xlog_recover_commit_trans Dave Chinner
2014-09-26 2:19 ` [PATCH 4/5] xfs: reorganise transaction recovery item code Dave Chinner
2014-09-26 12:05 ` Christoph Hellwig [this message]
2014-09-26 2:19 ` [PATCH 5/5] xfs: refactor recovery transaction start handling Dave Chinner
2014-09-26 12:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926120556.GC10574@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox